-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Align internal icons with mono-repository #1692
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/9bg5fvqhs |
Codecov Report
@@ Coverage Diff @@
## next #1692 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 73 73
Lines 2315 2315
Branches 402 402
=======================================
Hits 2078 2078
Misses 190 190
Partials 47 47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like not to move to default exports of React
at least for now.
And also interesting why visual regression didn't start? Probably because this is a forked branch. Need to investigate – I'd like to see what's changed after deleting paths from SVG.
What's the concern with the import, it seems we do it most of the time already? |
@oliviertassinari Sorry I am blind. For some reason I thought you moved
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
4fa2b8b
to
b1b3644
Compare
Icon
suffix