Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Align internal icons with mono-repository #1692

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 20, 2020

  • Remove redundant Icon suffix
  • Use import *
  • Label as internal, a deterrent for developers to import these icons
  • Remove useless paths

@vercel
Copy link

vercel bot commented Apr 20, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/9bg5fvqhs
✅ Preview: https://material-ui-pickers-git-fork-oliviertassinari-simpler-icons.mui-org.now.sh

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #1692 into next will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1692   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          73       73           
  Lines        2315     2315           
  Branches      402      402           
=======================================
  Hits         2078     2078           
  Misses        190      190           
  Partials       47       47           
Impacted Files Coverage Δ
lib/src/_shared/icons/ArrowDropDownIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/ArrowLeftIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/ArrowRightIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/CalendarIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/ClockIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/DateRangeIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/PenIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/TimeIcon.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e91bd...6f1bb86. Read the comment docs.

Copy link
Member

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like not to move to default exports of React at least for now.
And also interesting why visual regression didn't start? Probably because this is a forked branch. Need to investigate – I'd like to see what's changed after deleting paths from SVG.

@oliviertassinari
Copy link
Member Author

What's the concern with the import, it seems we do it most of the time already?
https://github.com/mui-org/material-ui-pickers/blob/0d41c48aaa8b9b6f67e72deee9583340cd218b89/lib/src/views/Clock/ClockNumber.tsx#L1

@dmtrKovalenko
Copy link
Member

image

But it is there ...
image

@dmtrKovalenko
Copy link
Member

dmtrKovalenko commented Apr 20, 2020

@oliviertassinari Sorry I am blind. For some reason I thought you moved *as to default. It is ok – thanks... my bad XD

Its left to figure out what's wrong with visual regression. It's for me probably

@cypress
Copy link

cypress bot commented Apr 21, 2020



Test summary

69 0 1 0


Run details

Project material-ui-pickers
Status Passed
Commit 6f1bb86
Started Apr 21, 2020 10:37 AM
Ended Apr 21, 2020 10:38 AM
Duration 01:14 💡
OS Linux Debian - 9.11
Browser Chrome 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@vercel vercel bot temporarily deployed to Preview April 21, 2020 10:32 Inactive
@dmtrKovalenko dmtrKovalenko merged commit 1c011a4 into mui:next Apr 21, 2020
@oliviertassinari oliviertassinari deleted the simpler-icons branch April 21, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants