-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "empty" value in pickers' UX #1770
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/ptsgd8bwd |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## next #1770 +/- ##
==========================================
+ Coverage 90.74% 91.15% +0.41%
==========================================
Files 77 77
Lines 2333 2364 +31
Branches 439 457 +18
==========================================
+ Hits 2117 2155 +38
+ Misses 174 169 -5
+ Partials 42 40 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement
This PR closes #1613
User facing changes
Breaking changes
value={null}
and the user didn't take any action. (previously it has been renderingdefaultHighlight
or now)defaultHighlight
propFeatures
value={null}
and the user didn't take any action. (previously it has been renderingdefaultHighlight
or now)toolbarPlaceholder
prop that will be displayed instead of day text whenvalue
isnull
. By default"––"