Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theme] Replace legacy theme.palette.text.hint with secondary #1952

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

dmtrKovalenko
Copy link
Member

@dmtrKovalenko dmtrKovalenko commented Jul 3, 2020

Closes #1680
Closes #1681

@vercel
Copy link

vercel bot commented Jul 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/gjkyxa5dq
✅ Preview: https://material-ui-pickers-git-feature-use-themepalettetextsecondary.mui-org.vercel.app

@cypress
Copy link

cypress bot commented Jul 3, 2020



Test summary

75 0 3 0


Run details

Project material-ui-pickers
Status Passed
Commit 2ecb62e
Started Jul 3, 2020 9:10 AM
Ended Jul 3, 2020 9:11 AM
Duration 01:37 💡
OS Linux Debian - 10.0
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next@510c745). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1952   +/-   ##
=======================================
  Coverage        ?   91.34%           
=======================================
  Files           ?       84           
  Lines           ?     2473           
  Branches        ?      468           
=======================================
  Hits            ?     2259           
  Misses          ?      174           
  Partials        ?       40           
Impacted Files Coverage Δ
lib/src/views/Calendar/Calendar.tsx 86.76% <ø> (ø)
lib/src/views/Calendar/Day.tsx 92.85% <ø> (ø)
lib/src/views/Calendar/Month.tsx 100.00% <ø> (ø)
lib/src/views/Calendar/Year.tsx 96.87% <ø> (ø)
lib/src/views/Clock/ClockNumber.tsx 97.22% <100.00%> (ø)
lib/src/Picker/Picker.tsx 93.75% <0.00%> (ø)
lib/src/views/Calendar/CalendarView.tsx 100.00% <0.00%> (ø)
lib/src/TimePicker/TimePickerToolbar.tsx 94.64% <0.00%> (ø)
lib/src/_shared/ArrowSwitcher.tsx 88.88% <0.00%> (ø)
lib/src/DateTimePicker/DateTimePicker.tsx 97.87% <0.00%> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510c745...2ecb62e. Read the comment docs.

@oliviertassinari oliviertassinari changed the title Replace theme.palette.text.hint with theme.palette.text.secondary [theme] Replace legacy theme.palette.text.hint with text.secondary Jul 3, 2020
@oliviertassinari oliviertassinari changed the title [theme] Replace legacy theme.palette.text.hint with text.secondary [theme] Replace legacy theme.palette.text.hint with secondary Jul 3, 2020
@dmtrKovalenko dmtrKovalenko merged commit e4c2bdd into next Jul 6, 2020
@dmtrKovalenko dmtrKovalenko deleted the feature/use-theme.palette.text.secondary branch July 6, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

theme.palette.text.hint is going away The border color of "today" doesn't match the spec
2 participants