Skip to content

Commit

Permalink
Merge pull request #185 from choonkending/fix_deprecated_arguments
Browse files Browse the repository at this point in the history
#169 arguments.callee is deprecated in strict mode for ecma 5
  • Loading branch information
hai-cea committed Jan 3, 2015
2 parents fe03ba3 + f62fd1f commit dc381c3
Showing 1 changed file with 29 additions and 21 deletions.
50 changes: 29 additions & 21 deletions src/js/utils/events.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
module.exports = {

once: function (el, type, callback) {
var typeArray = type.split(' ');

for (var i = typeArray.length - 1; i >= 0; i--) {
el.addEventListener(typeArray[i], function(e) {
e.target.removeEventListener(e.type, arguments.callee);
return callback(e);
});
};
},

on: function(el, type, callback, capture) {
el.addEventListener(type, callback, capture || false);
},

off: function(el, type, callback, capture) {
el.removeEventListener(type, callback, capture || false);
}

}
once: function(el, type, callback) {
var typeArray = type.split(' ');
var recursiveFunction = function(e){
e.target.removeEventListener(e.type, recursiveFunction);
return callback(e);
};
for(var i = typeArray.length - 1; i > 0; i--) {
on(el, typeArray[i], recursiveFunction);
}
},
// IE8+ Support
on: function(el, type, callback) {
if(el.addEventListener) {
el.addEventListener(type, callback);
} else {
el.attachEvent('on' + type, function() {
callback.call(el);
});
}
},
// IE8+ Support
off: function(el, type, callback) {
if(el.removeEventListener) {
el.removeEventListener(type, callback);
} else {
el.detachEvent('on' + type, callback);
}
}
};

0 comments on commit dc381c3

Please sign in to comment.