Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Map Transition components to Material Design transition types? #15330

Closed
kaycebasques opened this issue Apr 12, 2019 · 6 comments
Labels
component: transitions This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@kaycebasques
Copy link

I'm opening this as an issue because it might be something that you'd be willing to add to the docs. I can make the doc updates myself.

Right now I'm reviewing the Material Design official docs to figure out what type of transition I should use for a certain interaction. It would have been helpful to me if the MUI Transitions doc briefly mentioned which type of transition each component maps to. For example, the Slide transition seems to map to peer transitions.

@mbrookes mbrookes added the docs Improvements or additions to the documentation label Apr 12, 2019
@mbrookes
Copy link
Member

@kaycebasques The transitions predate that section, so there isn't a direct correspondence between them and the current Material spec. However for the couple in that section that do map, you could had a reference.

@oliviertassinari
Copy link
Member

@kaycebasques We have limited support for transitions. This issue is related to #4117. I wouldn't use the Slide transition for the demos of https://material.io/design/navigation/navigation-transitions.html#peer-transitions. At least, not in its current implementation. It's designed for complete screen entrance. We use it for the non swipeable version of the Drawer. I like how Vuetify implements it: https://vuetifyjs.com/en/framework/transitions#usage.

@mbrookes
Copy link
Member

It's designed for complete screen entrance.

That appears to be exactly what peer transitions describe.

@oliviertassinari
Copy link
Member

We can consider the example of the specification.

Capture d’écran 2019-04-13 à 12 32 19

The animation of the text fields can be implemented with the Slide X transition module of Vuetify. It's something we should probably support here.

The animation at the bottom can be implemented with react-swipeable-views. The Slider won't do it as we see the screen n°2 when moving from the screen n°3 to the n°1. However, if we are willing to give up on this point. Our Slider component might do it, to try.

@oliviertassinari oliviertassinari added the component: transitions This is the name of the generic UI component, not the React module! label Oct 10, 2020
@samuelsycamore
Copy link
Contributor

Is this issue still relevant in Q4 '23?

@samuelsycamore samuelsycamore changed the title Map Transition components to Material Design transition types? [material-ui][docs] Map Transition components to Material Design transition types? Nov 28, 2023
@mbrookes
Copy link
Member

@samuelsycamore I think we should close it at this point.

@mbrookes mbrookes closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: transitions This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

4 participants