Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectField] doesn't open when floatingLabelText is clicked #4218

Closed
jeffshaver opened this issue May 9, 2016 · 4 comments · Fixed by #4418
Closed

[SelectField] doesn't open when floatingLabelText is clicked #4218

jeffshaver opened this issue May 9, 2016 · 4 comments · Fixed by #4418
Labels
component: select This is the name of the generic UI component, not the React module! v0.x
Milestone
0.15.1 Release

Comments

@jeffshaver
Copy link

Problem description

If you provide SelectField with a floatingLabelText property and then click the SelectField where the floatingLabelText shows up, the SelectField doesn't actually open.

Steps to reproduce

  1. Add a SelectField with a floatingLabelText
  2. Hover mouse where the text is (note that its a text cursor style instead of a hand)
  3. Try to click. Notice that nothing happens.

Versions

  • Material-UI: 0.15.0
  • React: 15.0.2
  • Browser: Chrome (50.0.2661.94 m)
@jeffshaver
Copy link
Author

One way of fixing this issue is to also provide floatingLabelStyle={{pointerEvents: 'none'}}. This should probably be the default though

@nathanmarks nathanmarks added the bug 🐛 Something doesn't work label May 9, 2016
@mbrookes mbrookes added Regression and removed bug 🐛 Something doesn't work labels May 9, 2016
@mbrookes
Copy link
Member

mbrookes commented May 9, 2016

Seems to have broken between 0.14.4 and 0.15.0. @jeffshaver Care to submit a PR?

@jeffshaver
Copy link
Author

@mbrookes i wouldn't mind submitting a pr. but is the proposed solution (making pointerEvents: 'none') the solution your guys want implemented or is there another way to fix this?

@mbrookes
Copy link
Member

That should do the trick.

@jeffshaver jeffshaver changed the title SelectField doesn't open when floatingLabelText is clicked [SelectField] doesn't open when floatingLabelText is clicked May 12, 2016
jeffshaver added a commit to jeffshaver/material-ui that referenced this issue May 12, 2016
@jeffshaver
[SelectField] Fix clicking floatingTextLabel not not opening menu. cl…
979fc1f 
…oses mui#4218
@jeffshaver jeffshaver mentioned this issue May 12, 2016
Closed
3 tasks
@nMustaki nMustaki mentioned this issue May 18, 2016
Closed
@mbrookes mbrookes added this to the 0.15.1 Release milestone May 29, 2016
This was referenced Jun 3, 2016
Merged
Closed
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: select This is the name of the generic UI component, not the React module! v0.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Milestone
0.15.1 Release
Development

Successfully merging a pull request may close this issue.

[TextField] Fix floatingLabelText intercepting click events
5 participants
@mbrookes @oliviertassinari @nathanmarks @jeffshaver @zannager