Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectField] Invalid height when has floatingLabelText and empty value #4297

Closed
avocadowastaken opened this issue May 18, 2016 · 5 comments
Closed

[SelectField] Invalid height when has floatingLabelText and empty value #4297

avocadowastaken opened this issue May 18, 2016 · 5 comments
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! v0.x

Comments

@avocadowastaken
Copy link
Contributor

example
@mbrookes mbrookes added the bug 🐛 Something doesn't work label May 18, 2016
@sidot3291
Copy link

+1.

Looks like this is caused by the wrapper div having a height of 72px, and the inner div having a height of 100% and a margin-top of 14px.

Switching margin-top to padding-top should resolve, since padding-top is included within the height whereas margin-top is outside (with box-sizing:border-box).

Unfortunately I'm new to react/material-ui and don't know where I'd look to fix this. I'll keep digging.

@sidot3291
Copy link

I believe it's this:
https://github.com/callemall/material-ui/blob/c824ad8896e1a85afc4789ae570775133276da4f/src/TextField/TextField.js#L87

@ryantemple ryantemple mentioned this issue Jun 7, 2016
Closed
3 tasks
@tomascharad
Copy link

Do you guys have any temporary fix for this?

@ben-av
Copy link

ben-av commented Nov 21, 2016

Adding labelStyle={{height: '56px'}} fixed it for me, but super annoying

@oliviertassinari oliviertassinari added the component: select This is the name of the generic UI component, not the React module! label Mar 26, 2017
@oliviertassinari oliviertassinari mentioned this issue Sep 6, 2017
Merged
12 tasks
@JarLowrey
Copy link

My issue ended up being invalid alignment for inline forms, this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mbrookes @sidot3291 @ben-av @tomascharad @oliviertassinari @avocadowastaken @JarLowrey