-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] First implementation #8023
[Select] First implementation #8023
Conversation
@sebald I might not have the energy of going into the TypeScript coverage to begging with. I'm going to handle the unit tests now. |
@oliviertassinari sure. Do you want the typings to be part of the PR or should we create them after this is merged? |
@sebald I will try to write some, but I don't guarantee the outcome 😆 . So I would love to have you giving a second look. |
Will do 😄 |
@sebald Well, the |
@kybarg Thanks a lot for your original migration. It was a great help for this implementation! I have been taking advantage of some of your logic and some of your unit tests. |
Wow, this is awesome and impressive! I feel that a 🎉 reaction on the PR comment is not enough to express my gratefulness 😄 ! |
@oliviertassinari @kybarg thank you for the great work |
@oliviertassinari @kybarg awesome! |
@kybarg @oliviertassinari - you guys just made my day! Heartfelt Thank You. |
A big thanks to @kybarg 🎉
Menu
versiononBlur
not fired when tapping on the input #7018 as it's working nowselectField
/dropDownMenu
icon in custom theme #6427 as we have a new style override storyunderlineFocusStyle
not getting applied #5470 as we have a new style override storyautoWidth
featurenative
propertyAlso closes DropDownMenu issues as was used in the same context than the SelectField on the v0.x versions:
MenuProps