Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss OnTouchTap Dependency #5522

Closed
smcguinness opened this issue Nov 8, 2016 · 5 comments
Closed

Discuss OnTouchTap Dependency #5522

smcguinness opened this issue Nov 8, 2016 · 5 comments
Labels
discussion

Comments

@smcguinness
Copy link
Contributor

I just ran across this comment, facebook/react#6221 (comment), regarding changes to mobile Chrome & Safari about removing tap delay. Should the requirement go away or should it still wait for React 1.0?
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 8, 2016 •
edited
Loading

We have removed the onTouchTap dependency on the next branch as mobile browser support has quite improved. I think that we can close this issue.

@BlockChange
Copy link

BlockChange commented Nov 9, 2016 •
edited
Loading

Could this explain: #5527 ? At least at the iOS side that they removed the delay, thus creating an issue with the now unneeded onTouchTap?

@BlockChange BlockChange mentioned this issue Nov 9, 2016
Closed
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 9, 2016 •
edited
Loading

@BlockChange I couldn't reproduce your issue on my iOS simulator using the docs site. I'm closing this issue.

@lucasbento lucasbento mentioned this issue Nov 10, 2016
Closed
@KaboomFox
Copy link

KaboomFox commented Dec 7, 2016 •
edited
Loading

@oliviertassinari this happens for me using mui 16.4, react 15.4.0 on iphone 7+ ios 10 chrome 54.

@KaboomFox
Copy link

I unfortunately have to use onTouchTap because my appBar uses two different left icons and the appBar component checks for onTouchTap as a prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smcguinness @KaboomFox @oliviertassinari @BlockChange