Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping any surface will show iOS keyboard. #5527

Closed
BlockChange opened this issue Nov 9, 2016 · 7 comments
Closed

Tapping any surface will show iOS keyboard. #5527

BlockChange opened this issue Nov 9, 2016 · 7 comments
Labels
bug 🐛 Something doesn't work

Comments

@BlockChange
Copy link

For some reason on iOS whenever any piece of paper or other mui elements are tapped, (like the BottomNavigation) the iOS keyboard shows up, in safari & chrome.

This problem does not occur on the web or on Android (both chrome)

Any ideas why this happens? Anyone had this happen before?

I don't have access to an iOS device to continuously test this.

I'm googling this issue but it doesn't seem a know issue thusfar.

Mui: v0.16.1
React: 15.3.2

@BlockChange
Copy link
Author

Ok, what I did is replace all onTouchTap events with onClick and remove the injectTapEventPlugin, this fixed the issue...

Anyone know if injectTapEventPlugin is still needed for modern(ish) browsers OSes? I don't have to support Internet Explorer or other outdated browsers.

@BlockChange
Copy link
Author

Might be related to: #5522

@ghost
Copy link

ghost commented Nov 30, 2016

I am having the same issue on iOS device on safari. Chrome ok.

Mui: v0.16.1
React: 15.3.1

@KaboomFox
Copy link

KaboomFox commented Dec 7, 2016

I am having the issue with mui 16.4 and react 15.4 with iphone 7 chrome 54.

@BlockChange BlockChange reopened this Dec 8, 2016
@nealeu
Copy link
Contributor

nealeu commented Jan 11, 2017

Would it be useful for there to be an interim release between current master and next which would be master but without the touchtap plugin and onTouchTap replaced with onClick?

This would be a good stepping stone for later consuming the next branch changes, and is what I'm doing at the moment to get a version that doesn't require the plugin.

Touch tap events could possibly be done with React Tappable instead of the plugin as now suggested at http://stackoverflow.com/a/34015469/1998186.

@oliviertassinari
Copy link
Member

Would it be useful for there to be an interim release between current master and next which would be master but without the touchtap plugin and onTouchTap replaced with onClick?

@nealeu That's something we could have done, however, I have a low incentive in going into that direction. I have been migration my app a long time ago to the v1-beta branch. The less I work on the master branch and the more appealing the v1-beta branch is the better. I'm closing as the v1-beta branch is no longer using the plugin.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jul 28, 2017
@nealeu
Copy link
Contributor

nealeu commented Jul 29, 2017

Yes. Totally agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

4 participants