Added Controllability to Tabs Component #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-cea
pushed a commit
that referenced
this pull request
Jul 21, 2015
Added Controllability to Tabs Component
|
Nice! |
|
I like the new |
Merged
|
Waiting for |
zannager
added
the
component: tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs are now controllable with this PR. Passing a value prop will allow you to programmatically choose which Tab is active or if no Tab is selected at all. If no value prop is passed, Tabs work normally as they have worked before this PR.
Breaking Changes: onChange(tabIndex, tab) now receives onChange(e, tab)
Fix: You can access the tabIndex of the tab by simply writing tabIndex = tab.props.tabIndex;