Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix recompose version #12605

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Conversation

yamachu
Copy link
Contributor

@yamachu yamachu commented Aug 21, 2018

ref: #12407
and so on.

recompose 2.8.0 and 2.8.1 depend ^@babel/runtime@7.0.0-beta.55,
but in 2.8.2, version has been fixed to @babel/runtime@7.0.0-beta.56
acdlite/recompose#724

So, it would be better to change "recompose": "^0.28.0" to recompose": "^0.28.2"

@oliviertassinari oliviertassinari changed the title [Core][Icons] Fix recompose version [core] Fix recompose version Aug 21, 2018
@mbrookes
Copy link
Member

mbrookes commented Aug 21, 2018

"^0.28.0" already includes 0.28.2

@eps1lon
Copy link
Member

eps1lon commented Aug 21, 2018

I think the goal is to force a project that has an existing lockfile to bump their recompose version.

Maybe package managers already bump transitive dependencies. If this actually resolved in an issue I'd like to see the lockfile.

@yamachu You need to update the lockfile.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 21, 2018

Yes, most of the fuss with the babel thing comes from recompose not using a fixed version between @babel/runtime and @babel/plugin-transform-runtime. We did the same mistake some weeks ago. 0.28.2 solves the issue, by bumping the version on Material-UI side, we invalidate everybody package resolution cache, and make issues like #12587 go away.

@oliviertassinari oliviertassinari merged commit 012333e into mui:master Aug 21, 2018
@oliviertassinari
Copy link
Member

@yamachu It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot!

marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
* [core] fix recompose version

* [icons] fix recompose version

* let's merge
@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants