[GridList] - new component #1320
Conversation
|
Any news? |
|
As you can see, no core contrubutor/owner did comment on this PR. So, I suppose there's little interest in this component. I use it in my own app and I also did a Virtual Grid List for the huge number of items use case. But I cannot do a PR with it until this one is not merged. |
|
this PR can't be merge, you will have to rebase |
|
I'll be using this (local copy while this is not merged). |
|
@igorbt please rebase when you get a chance so we can go ahead and merge this :) |
|
wow, very good! Thank you. |
|
OK, I think I can find some time to rebase this week. That's a pretty old PR so I think some refactoring may be needed. |
|
@igorbt looking forward to it! |
Simple flex-box based Grid List (https://www.google.com/design/spec/components/grid-lists.html) implementation. Support only tiles with 1x1 cell size.
After 0.12.0 breaking changes for theming, spacing and components themes are accessed in a different way.
|
OK, I did the rebase. Didn't invest too much time in a refactoring, just updated the way theming variables are accessed. So, I'm open to code improvements suggestions if any. |
| @@ -0,0 +1,68 @@ | |||
| let React = require('react/addons'); | |||
There was a problem hiding this comment.
Do you need addons here?
Made both components to be consistent with other components in how muiTheme is handled.
|
@oliviertassinari, you were right, I didn't need react/addons there. After all, I didn't use PureRenderMixin from the addons as I intended. Meanwhile I saw that I needed to refactor the way muiTheme is handled, I saw that all components now put it in the state. While I see the benefit of it, IMHO this adds a bit of boilerplate code to all the components (I basically copy-pasted ~20 lines from other component and I HATE copy-pasting). |
|
I'll go ahead and merge this. We can take any issues that come along the way :-) |
Simple flex-box based Grid List implementation. Support tiles with arbitrary cell size, but cannot implement complex layouts (like Angular Material GridList), is limited to flex-box limitations.
