[Tabs] Improve accessibility #16384
Merged
[Tabs] Improve accessibility #16384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 42f78c6...8d02f31
|
mbrookes
added
the
component: tabs
joshwooding
approved these changes
Jun 26, 2019
joshwooding
reviewed
Jun 26, 2019
|
Should add that I was already aware of typescript complaining about |
eps1lon
reviewed
Jun 27, 2019
|
It will help with https://darekkay.com/blog/accessible-ui-frameworks/ :) |
|
I had forgotten, but that post was what originally inspired me to look at it! |
oliviertassinari
force-pushed
the
tabs-a11y
branch
4 times, most recently
from
85ddc9d
to
36ddc06
Compare
oliviertassinari
approved these changes
Jul 13, 2019
There was a problem hiding this comment.
@mbrookes I have tried an approach to minimize the boilerplate as well as fix the build. Let me know what you think about it.
👍 for improving our demos 😍
oliviertassinari
force-pushed
the
tabs-a11y
branch
2 times, most recently
from
f88f6c2
to
8141a0e
Compare
oliviertassinari
force-pushed
the
tabs-a11y
branch
from
8141a0e
to
6d10ea6
Compare
eps1lon
reviewed
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an earlier attempt at improving the accessibility of the Tabs component. The plan was to complete the rest of the demos once the approach is agreed.
It originally had the beginnings of better keyboard support, but I removed that after it was going to be handled either separately or more holistically. As it stands better ARIA support without proper keyboard support is a bit pointless, but hopefully it's still a step in the right direction.
Regarding TabPanel, even though it's small, since we repeat it in every demo, I wonder if this should be a fully fledged component?
It would also be good to be able to get rid of the some of the boilerplate by automating the id generation, similar to what we do in SpeedDial. The simple tabs demo is a lot more verbose now.