-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs] Fix issue where scrollable tabs auto move to selected tab #16961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: f2dbeca...6563fd0
|
FYI I ran
|
oliviertassinari
added
component: tabs
This is the name of the generic UI component, not the React module!
bug 🐛
Something doesn't work
PR: good for merge
labels
Aug 12, 2019
oliviertassinari
approved these changes
Aug 12, 2019
@wereHamster Well done, thanks for taking care of the issue! |
aloiret
pushed a commit
to aloiret/material-ui
that referenced
this pull request
Aug 15, 2019
aloiret
pushed a commit
to aloiret/material-ui
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: tabs
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10826
The diff is based on the suggestion by @oliviertassinari, though the Tabs code has changed somewhat in the meantime (due to the change to use React hooks and the addition of vertical Tabs).
The original issue was reported against Firefox, but I was able to reproduce it on Edge as well. I currently don't have access to Edge, but can test it later.
Is it possible to write a test for something like that?