Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useMediaQuery] Workaround Safari wrong implementation of matchMedia #17315

Merged
merged 2 commits into from
Sep 5, 2019
Merged

[useMediaQuery] Workaround Safari wrong implementation of matchMedia #17315

merged 2 commits into from
Sep 5, 2019

Commits on Sep 4, 2019

  1. For useMediaQuery(), don't call setState() once unmounting begins. Th… 

    …is may have happened in cases such as if a component unmounts when a window resizes. Pattern used is from: https://reactjs.org/docs/hooks-faq.html#is-it-safe-to-omit-functions-from-the-list-of-dependencies
    @momentpaul
    momentpaul committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    779abba View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. add comment

    @oliviertassinari
    oliviertassinari committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    a52f004 View commit details
    Browse the repository at this point in the history