Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve theme.breakpoints description #19065

Merged
merged 2 commits into from
Jan 3, 2020
Merged

[docs] Improve theme.breakpoints description #19065

merged 2 commits into from
Jan 3, 2020

Conversation

littleee
Copy link
Contributor

@littleee littleee commented Jan 3, 2020 •
edited
Loading

@songliling
Copy link

good job

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 3, 2020 •
edited
Loading

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes.

Comparing: 2f7b71c...9b4eaf0

bundle Size Change Size Gzip Change Gzip
docs.main ▲ +614 kB (+Infinity% ) 614 kB ▲ +196 kB (+Infinity% ) 196 kB
@material-ui/core ▲ +358 kB (+Infinity% ) 358 kB ▲ +98.2 kB (+Infinity% ) 98.2 kB
@material-ui/core[umd] ▲ +314 kB (+Infinity% ) 314 kB ▲ +90.6 kB (+Infinity% ) 90.6 kB
@material-ui/lab ▲ +182 kB (+Infinity% ) 182 kB ▲ +54.6 kB (+Infinity% ) 54.6 kB
TablePagination ▲ +141 kB (+Infinity% ) 141 kB ▲ +41.3 kB (+Infinity% ) 41.3 kB
Autocomplete ▲ +129 kB (+Infinity% ) 129 kB ▲ +40.6 kB (+Infinity% ) 40.6 kB
TextField ▲ +123 kB (+Infinity% ) 123 kB ▲ +36.1 kB (+Infinity% ) 36.1 kB
SpeedDialAction ▲ +117 kB (+Infinity% ) 117 kB ▲ +37.1 kB (+Infinity% ) 37.1 kB
Select ▲ +114 kB (+Infinity% ) 114 kB ▲ +34 kB (+Infinity% ) 34 kB
Tooltip ▲ +101 kB (+Infinity% ) 101 kB ▲ +31.9 kB (+Infinity% ) 31.9 kB
SwipeableDrawer ▲ +91.6 kB (+Infinity% ) 91.6 kB ▲ +28.7 kB (+Infinity% ) 28.7 kB
Menu ▲ +88.2 kB (+Infinity% ) 88.2 kB ▲ +27.3 kB (+Infinity% ) 27.3 kB
SpeedDial ▲ +85.8 kB (+Infinity% ) 85.8 kB ▲ +27.1 kB (+Infinity% ) 27.1 kB
Tabs ▲ +85.2 kB (+Infinity% ) 85.2 kB ▲ +27.1 kB (+Infinity% ) 27.1 kB
Drawer ▲ +84.2 kB (+Infinity% ) 84.2 kB ▲ +25.7 kB (+Infinity% ) 25.7 kB
Alert ▲ +83.5 kB (+Infinity% ) 83.5 kB ▲ +26.2 kB (+Infinity% ) 26.2 kB
ButtonGroup ▲ +82.9 kB (+Infinity% ) 82.9 kB ▲ +25.5 kB (+Infinity% ) 25.5 kB
Radio ▲ +82.7 kB (+Infinity% ) 82.7 kB ▲ +26.2 kB (+Infinity% ) 26.2 kB
Popover ▲ +82.5 kB (+Infinity% ) 82.5 kB ▲ +25.7 kB (+Infinity% ) 25.7 kB
Dialog ▲ +82.5 kB (+Infinity% ) 82.5 kB ▲ +25.9 kB (+Infinity% ) 25.9 kB
Chip ▲ +82.3 kB (+Infinity% ) 82.3 kB ▲ +25.3 kB (+Infinity% ) 25.3 kB
StepButton ▲ +82 kB (+Infinity% ) 82 kB ▲ +26 kB (+Infinity% ) 26 kB
Checkbox ▲ +81.7 kB (+Infinity% ) 81.7 kB ▲ +25.9 kB (+Infinity% ) 25.9 kB
Switch ▲ +80.9 kB (+Infinity% ) 80.9 kB ▲ +25.5 kB (+Infinity% ) 25.5 kB
Button ▲ +79.4 kB (+Infinity% ) 79.4 kB ▲ +24.4 kB (+Infinity% ) 24.4 kB
MenuItem ▲ +77.9 kB (+Infinity% ) 77.9 kB ▲ +24.4 kB (+Infinity% ) 24.4 kB
ExpansionPanelSummary ▲ +77.8 kB (+Infinity% ) 77.8 kB ▲ +24.6 kB (+Infinity% ) 24.6 kB
TableSortLabel ▲ +77.1 kB (+Infinity% ) 77.1 kB ▲ +24.3 kB (+Infinity% ) 24.3 kB
ListItem ▲ +76.9 kB (+Infinity% ) 76.9 kB ▲ +24.1 kB (+Infinity% ) 24.1 kB
NativeSelect ▲ +76.6 kB (+Infinity% ) 76.6 kB ▲ +24.2 kB (+Infinity% ) 24.2 kB
Fab ▲ +76.5 kB (+Infinity% ) 76.5 kB ▲ +23.9 kB (+Infinity% ) 23.9 kB
Tab ▲ +76.1 kB (+Infinity% ) 76.1 kB ▲ +24.1 kB (+Infinity% ) 24.1 kB
ToggleButton ▲ +75.9 kB (+Infinity% ) 75.9 kB ▲ +24.1 kB (+Infinity% ) 24.1 kB
IconButton ▲ +75.9 kB (+Infinity% ) 75.9 kB ▲ +23.7 kB (+Infinity% ) 23.7 kB
Slider ▲ +75.3 kB (+Infinity% ) 75.3 kB ▲ +23.9 kB (+Infinity% ) 23.9 kB
BottomNavigationAction ▲ +75.2 kB (+Infinity% ) 75.2 kB ▲ +23.8 kB (+Infinity% ) 23.8 kB
Snackbar ▲ +74.9 kB (+Infinity% ) 74.9 kB ▲ +23.5 kB (+Infinity% ) 23.5 kB
CardActionArea ▲ +74.8 kB (+Infinity% ) 74.8 kB ▲ +23.6 kB (+Infinity% ) 23.6 kB
OutlinedInput ▲ +73.7 kB (+Infinity% ) 73.7 kB ▲ +23 kB (+Infinity% ) 23 kB
ButtonBase ▲ +73.7 kB (+Infinity% ) 73.7 kB ▲ +23.2 kB (+Infinity% ) 23.2 kB
TreeItem ▲ +73.5 kB (+Infinity% ) 73.5 kB ▲ +23.3 kB (+Infinity% ) 23.3 kB
FilledInput ▲ +73.3 kB (+Infinity% ) 73.3 kB ▲ +22.8 kB (+Infinity% ) 22.8 kB
Input ▲ +72.2 kB (+Infinity% ) 72.2 kB ▲ +22.6 kB (+Infinity% ) 22.6 kB
ExpansionPanel ▲ +71.1 kB (+Infinity% ) 71.1 kB ▲ +22.3 kB (+Infinity% ) 22.3 kB
Box ▲ +70.5 kB (+Infinity% ) 70.5 kB ▲ +21.5 kB (+Infinity% ) 21.5 kB
InputBase ▲ +70.3 kB (+Infinity% ) 70.3 kB ▲ +22.1 kB (+Infinity% ) 22.1 kB
Rating ▲ +70 kB (+Infinity% ) 70 kB ▲ +22.5 kB (+Infinity% ) 22.5 kB
StepContent ▲ +68.8 kB (+Infinity% ) 68.8 kB ▲ +21.6 kB (+Infinity% ) 21.6 kB
StepLabel ▲ +68.3 kB (+Infinity% ) 68.3 kB ▲ +21.6 kB (+Infinity% ) 21.6 kB
Breadcrumbs ▲ +67.7 kB (+Infinity% ) 67.7 kB ▲ +21.3 kB (+Infinity% ) 21.3 kB
Collapse ▲ +67.6 kB (+Infinity% ) 67.6 kB ▲ +21 kB (+Infinity% ) 21 kB
MobileStepper ▲ +67.6 kB (+Infinity% ) 67.6 kB ▲ +21.3 kB (+Infinity% ) 21.3 kB
Backdrop ▲ +67.5 kB (+Infinity% ) 67.5 kB ▲ +20.9 kB (+Infinity% ) 20.9 kB
Link ▲ +66.4 kB (+Infinity% ) 66.4 kB ▲ +21 kB (+Infinity% ) 21 kB
TreeView ▲ +66.1 kB (+Infinity% ) 66.1 kB ▲ +20.8 kB (+Infinity% ) 20.8 kB
MenuList ▲ +65.7 kB (+Infinity% ) 65.7 kB ▲ +20.6 kB (+Infinity% ) 20.6 kB
Hidden ▲ +65.7 kB (+Infinity% ) 65.7 kB ▲ +20.7 kB (+Infinity% ) 20.7 kB
FormControlLabel ▲ +65.3 kB (+Infinity% ) 65.3 kB ▲ +20.5 kB (+Infinity% ) 20.5 kB
LinearProgress ▲ +65.1 kB (+Infinity% ) 65.1 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
Badge ▲ +65.1 kB (+Infinity% ) 65.1 kB ▲ +20.3 kB (+Infinity% ) 20.3 kB
InputLabel ▲ +65.1 kB (+Infinity% ) 65.1 kB ▲ +20.1 kB (+Infinity% ) 20.1 kB
Avatar ▲ +65 kB (+Infinity% ) 65 kB ▲ +20.6 kB (+Infinity% ) 20.6 kB
Grid ▲ +64.9 kB (+Infinity% ) 64.9 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
InputAdornment ▲ +64.8 kB (+Infinity% ) 64.8 kB ▲ +20.5 kB (+Infinity% ) 20.5 kB
CardHeader ▲ +64.8 kB (+Infinity% ) 64.8 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
ListItemText ▲ +64.7 kB (+Infinity% ) 64.7 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
Stepper ▲ +64.6 kB (+Infinity% ) 64.6 kB ▲ +20.4 kB (+Infinity% ) 20.4 kB
StepIcon ▲ +64.4 kB (+Infinity% ) 64.4 kB ▲ +20.1 kB (+Infinity% ) 20.1 kB
SpeedDialIcon ▲ +64.3 kB (+Infinity% ) 64.3 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
FormControl ▲ +64.1 kB (+Infinity% ) 64.1 kB ▲ +20 kB (+Infinity% ) 20 kB
DialogTitle ▲ +64 kB (+Infinity% ) 64 kB ▲ +20.1 kB (+Infinity% ) 20.1 kB
AlertTitle ▲ +63.9 kB (+Infinity% ) 63.9 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
CircularProgress ▲ +63.9 kB (+Infinity% ) 63.9 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
DialogContentText ▲ +63.8 kB (+Infinity% ) 63.8 kB ▲ +20.1 kB (+Infinity% ) 20.1 kB
TableCell ▲ +63.8 kB (+Infinity% ) 63.8 kB ▲ +20.2 kB (+Infinity% ) 20.2 kB
AppBar ▲ +63.7 kB (+Infinity% ) 63.7 kB ▲ +20 kB (+Infinity% ) 20 kB
GridListTile ▲ +63.5 kB (+Infinity% ) 63.5 kB ▲ +20 kB (+Infinity% ) 20 kB
Typography ▲ +63.4 kB (+Infinity% ) 63.4 kB ▲ +19.9 kB (+Infinity% ) 19.9 kB
SnackbarContent ▲ +63.3 kB (+Infinity% ) 63.3 kB ▲ +20 kB (+Infinity% ) 20 kB
FormLabel ▲ +63.2 kB (+Infinity% ) 63.2 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
RadioGroup ▲ +63.2 kB (+Infinity% ) 63.2 kB ▲ +19.9 kB (+Infinity% ) 19.9 kB
FormHelperText ▲ +63 kB (+Infinity% ) 63 kB ▲ +19.8 kB (+Infinity% ) 19.8 kB
Container ▲ +63 kB (+Infinity% ) 63 kB ▲ +19.8 kB (+Infinity% ) 19.8 kB
GridListTileBar ▲ +63 kB (+Infinity% ) 63 kB ▲ +19.8 kB (+Infinity% ) 19.8 kB
ToggleButtonGroup ▲ +63 kB (+Infinity% ) 63 kB ▲ +19.9 kB (+Infinity% ) 19.9 kB
SvgIcon ▲ +62.8 kB (+Infinity% ) 62.8 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
Skeleton ▲ +62.7 kB (+Infinity% ) 62.7 kB ▲ +19.9 kB (+Infinity% ) 19.9 kB
Card ▲ +62.6 kB (+Infinity% ) 62.6 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
Icon ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
ListSubheader ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
StepConnector ▲ +62.5 kB (+Infinity% ) 62.5 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
Step ▲ +62.4 kB (+Infinity% ) 62.4 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
Divider ▲ +62.3 kB (+Infinity% ) 62.3 kB ▲ +19.7 kB (+Infinity% ) 19.7 kB
Table ▲ +62.3 kB (+Infinity% ) 62.3 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
TableRow ▲ +62.3 kB (+Infinity% ) 62.3 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
GridList ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
BottomNavigation ▲ +62.2 kB (+Infinity% ) 62.2 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
List ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
Paper ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
CardMedia ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
Toolbar ▲ +62.1 kB (+Infinity% ) 62.1 kB ▲ +19.6 kB (+Infinity% ) 19.6 kB
AvatarGroup ▲ +62 kB (+Infinity% ) 62 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
DialogContent ▲ +62 kB (+Infinity% ) 62 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
ListItemIcon ▲ +61.9 kB (+Infinity% ) 61.9 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
ListItemAvatar ▲ +61.9 kB (+Infinity% ) 61.9 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
TableFooter ▲ +61.9 kB (+Infinity% ) 61.9 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
TableHead ▲ +61.9 kB (+Infinity% ) 61.9 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
TableBody ▲ +61.9 kB (+Infinity% ) 61.9 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
DialogActions ▲ +61.9 kB (+Infinity% ) 61.9 kB ▲ +19.5 kB (+Infinity% ) 19.5 kB
ExpansionPanelActions ▲ +61.8 kB (+Infinity% ) 61.8 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
CardActions ▲ +61.8 kB (+Infinity% ) 61.8 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
FormGroup ▲ +61.8 kB (+Infinity% ) 61.8 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
ListItemSecondaryAction ▲ +61.8 kB (+Infinity% ) 61.8 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
CardContent ▲ +61.7 kB (+Infinity% ) 61.7 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
TableContainer ▲ +61.7 kB (+Infinity% ) 61.7 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
ExpansionPanelDetails ▲ +61.7 kB (+Infinity% ) 61.7 kB ▲ +19.4 kB (+Infinity% ) 19.4 kB
CssBaseline ▲ +57.3 kB (+Infinity% ) 57.3 kB ▲ +18 kB (+Infinity% ) 18 kB
@material-ui/styles ▲ +50.8 kB (+Infinity% ) 50.8 kB ▲ +15.3 kB (+Infinity% ) 15.3 kB
docs.landing ▲ +50.7 kB (+Infinity% ) 50.7 kB ▲ +13.4 kB (+Infinity% ) 13.4 kB
Popper ▲ +28.7 kB (+Infinity% ) 28.7 kB ▲ +10.3 kB (+Infinity% ) 10.3 kB
Slide ▲ +25.3 kB (+Infinity% ) 25.3 kB ▲ +8.72 kB (+Infinity% ) 8.72 kB
Grow ▲ +23.9 kB (+Infinity% ) 23.9 kB ▲ +8.21 kB (+Infinity% ) 8.21 kB
Zoom ▲ +23.4 kB (+Infinity% ) 23.4 kB ▲ +8.11 kB (+Infinity% ) 8.11 kB
Fade ▲ +23.3 kB (+Infinity% ) 23.3 kB ▲ +8 kB (+Infinity% ) 8 kB
styles/createMuiTheme ▲ +16.5 kB (+Infinity% ) 16.5 kB ▲ +5.85 kB (+Infinity% ) 5.85 kB
@material-ui/system ▲ +14.5 kB (+Infinity% ) 14.5 kB ▲ +4.04 kB (+Infinity% ) 4.04 kB
Modal ▲ +14.3 kB (+Infinity% ) 14.3 kB ▲ +5.01 kB (+Infinity% ) 5.01 kB
useAutocomplete ▲ +12.7 kB (+Infinity% ) 12.7 kB ▲ +4.71 kB (+Infinity% ) 4.71 kB
TextareaAutosize ▲ +5.09 kB (+Infinity% ) 5.09 kB ▲ +2.14 kB (+Infinity% ) 2.14 kB
RootRef ▲ +4.21 kB (+Infinity% ) 4.21 kB ▲ +1.64 kB (+Infinity% ) 1.64 kB
ClickAwayListener ▲ +3.85 kB (+Infinity% ) 3.85 kB ▲ +1.54 kB (+Infinity% ) 1.54 kB
colorManipulator ▲ +3.85 kB (+Infinity% ) 3.85 kB ▲ +1.52 kB (+Infinity% ) 1.52 kB
Portal ▲ +2.9 kB (+Infinity% ) 2.9 kB ▲ +1.3 kB (+Infinity% ) 1.3 kB
useMediaQuery ▲ +2.5 kB (+Infinity% ) 2.5 kB ▲ +1.06 kB (+Infinity% ) 1.06 kB
NoSsr ▲ +2.19 kB (+Infinity% ) 2.19 kB ▲ +1.03 kB (+Infinity% ) 1.03 kB

Generated by 🚫 dangerJS against 9b4eaf0

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 3, 2020
@oliviertassinari oliviertassinari changed the title [docs] fix breakpoints.md [docs] Improve theme.breakpoints description Jan 3, 2020
@oliviertassinari oliviertassinari merged commit ee46512 into mui:master Jan 3, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 3, 2020 •
edited
Loading

@littleee Thank you!

With #13448 we will simplify the breakpoint concept, right now, a breakpoint is both a value and an interval. It will be simpler as a value only.

m4theushw pushed a commit to m4theushw/material-ui that referenced this pull request Jan 6, 2020
@littleee @m4theushw
[docs] Improve theme.breakpoints description (mui#19065)
edd0aba
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@littleee @songliling @mui-pr-bot @oliviertassinari