Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DialogContentText] Fix component prop #19102

Merged
merged 1 commit into from
Jan 9, 2020
Merged

[DialogContentText] Fix component prop #19102

merged 1 commit into from
Jan 9, 2020

Conversation

fyodore82
Copy link
Contributor

@fyodore82 fyodore82 commented Jan 6, 2020 •
edited by oliviertassinari
Loading

As DialogContentText is based wrapper around Typography, DialogContentTextProps is almost the same as TypographyProps

Closes #19068

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 6, 2020 •
edited
Loading

No bundle size changes comparing 6e3c7ab...9baa259

Generated by 🚫 dangerJS against 9baa259

@oliviertassinari oliviertassinari changed the title [DialogContentText] Fix component prop (#19068) [DialogContentText] Fix component prop Jan 6, 2020
@oliviertassinari oliviertassinari added component: dialog This is the name of the generic UI component, not the React module! typescript labels Jan 7, 2020
@oliviertassinari
Copy link
Member

@fyodore82 Thanks for the fix and the tests!

@oliviertassinari oliviertassinari merged commit e5b2e22 into mui:master Jan 9, 2020
@oliviertassinari
Copy link
Member

@fyodore82 Thank you

@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
Merged
This was referenced Mar 20, 2020
Merged
Merged
This was referenced Apr 6, 2020
Open
Closed
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error when setting component on DialogContentText
3 participants
@fyodore82 @mui-pr-bot @oliviertassinari