Bump rollup-plugin-terser from 5.1.3 to 5.2.0 #19186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
|
@material-ui/core: parsed: +0.44% , gzip: +0.09% Details of bundle changes.Comparing: ca8c102...39d7c98
|
Bumps [rollup-plugin-terser](https://github.com/TrySound/rollup-plugin-terser) from 5.1.3 to 5.2.0. - [Release notes](https://github.com/TrySound/rollup-plugin-terser/releases) - [Commits](TrySound/rollup-plugin-terser@v5.1.3...v5.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview
bot
force-pushed
the
dependabot/npm_and_yarn/rollup-plugin-terser-5.2.0
branch
from
a7e35c9
to
39d7c98
Compare
eps1lon
reviewed
Jan 14, 2020
| resolved "https://registry.yarnpkg.com/terser/-/terser-4.1.2.tgz#b2656c8a506f7ce805a3f300a2ff48db022fa391" | ||
| integrity sha512-jvNoEQSPXJdssFwqPSgWjsOrb+ELoE+ILpHPKXC83tIxOlh2U75F1KuB2luLD/3a6/7K3Vw5pDn+hvu0C4AzSw== | ||
| terser@3.16.1, terser@^4.1.2, terser@^4.6.2: | ||
| version "4.6.2" |
There was a problem hiding this comment.
Bisecting the upgrade to terser to understand what's happening...
I suspect this is necessary to prevent bugs in certain edge cases but the increase is larger than I would expect.
There was a problem hiding this comment.
Biggest bump from 4.2.1 to 4.3.0. Still upgrading to be safe. Next time this happens I'll take a look what exactly happened and if we can help terser by specifying options.
There was a problem hiding this comment.
In this release I enabled toplevel by default for cjs format. Can it be related?
There was a problem hiding this comment.
The bump happens when only updating terser as well which is why our docs bundle size also increased. As I said most of the increased happens when bumping terser from 4.2.1 to 4.3.0.
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/rollup-plugin-terser-5.2.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rollup-plugin-terser from 5.1.3 to 5.2.0.
Release notes
Sourced from rollup-plugin-terser's releases.
Commits
b683311v5.2.05c43828Upgrade dependencies4b50a48Add note about default options5503c23Enable toplevel by default for cjs format and allow to override optionsf23a346Fix nameCache (#62)9243334Upgrade rollup and fix testDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: