Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve draggable dialog demo #19339

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Conversation

konekoya
Copy link
Contributor

@konekoya konekoya commented Jan 21, 2020

Since we're explicitly setting style={{ cursor: 'move' }} in the DialogTitle. We should also make sure only the title is "draggle", not the whole dialog.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 21, 2020

No bundle size changes comparing 2082679...31792e6

Generated by 🚫 dangerJS against 31792e6

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Jan 21, 2020
@eps1lon
Copy link
Member

eps1lon commented Jan 21, 2020

Thanks for working on this.

Could you apply the same patch to the DraggableDialog.tsx as well? Then test_types should pass.

@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Jan 21, 2020
@konekoya
Copy link
Contributor Author

Could you apply the same patch to the DraggableDialog.tsx as well? Then test_types should pass.

Thanks for the help @eps1lon! The PR has been updated and everything is passing :)

@eps1lon eps1lon merged commit 820ad88 into mui:master Jan 22, 2020
@eps1lon
Copy link
Member

eps1lon commented Jan 22, 2020

@konekoya Nice catch, thanks.

@konekoya konekoya deleted the dialog-handle branch January 22, 2020 04:00
@konekoya
Copy link
Contributor Author

@konekoya Nice catch, thanks.

No problem! Thanks for the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants