Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blog] 2019 in review and beyond #19478
[blog] 2019 in review and beyond #19478
Changes from 2 commits
3d54ff2
edfb229
94c917f
96b10e9
ace3783
a81e1bd
f2e2612
551bb19
0af20e2
def2b61
0402840
825bab5
77aa444
cf897c4
e424654
f9df403
4ca6fd7
9172fd9
7b3749e
aeb5d02
caf1655
e93e995
f11cb7e
7b39dfb
1fcd8b9
897ca65
b24e2ed
debe2fe
d21aeb5
e52eb34
981ac72
931cc72
eea64e8
97b53d4
ca9769f
a0bcb6e
e4c98fc
253f59c
f28450d
98680ac
bd5fd2a
d35b00d
ffc5f31
fdeb832
1174266
950640d
199290f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to add a bullet list summary of the key benefits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Store for Material-UI themes?
Or
theme store for Material-UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that "theme" is too restrictive, our users seem to value templates and design assets as much as themes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshwooding We'll probably change the name too. Perhaps it should have been store.material-ui.com to start with; and it may yet move under the primary domain (TBD).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was always the intention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it hundreds of thousands, or a million ("About us").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the difference is in the considered period. Here we mention a month, in the "About Us" section, it's a fuzzy longer period.