-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TablePagination] Support unknown total count #19494
Conversation
Details of bundle changes.Comparing: ac5c1ae...623fbc9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. I believe it will cover the unknown total count use case well.
Note that the l10n will need an update after these changes.
This PR add the possibity to show server side pagination for an unknown number of rows if count -1 is provided.
I added the german I10n but I do not know the other languages. |
Awesome, I can't wait to put this feature at use in the data grid. For the translations, I believe that the community will jump in if we successfully make it use the feature. So I wouldn't worry too much about it. |
This PR add the possibility to show server side pagination for an unknown number of rows if count -1 is provided.
This will enable the data grid component to be server side rendered without knowing the total amount of rows and the 'labelDisplayedRows' does not have to overwritten for this usecase.