Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add cinemaPlus to showcase #19502

Merged
merged 3 commits into from
Feb 1, 2020
Merged

[docs] Add cinemaPlus to showcase #19502

merged 3 commits into from
Feb 1, 2020

Conversation

georgesimos
Copy link
Contributor

@georgesimos georgesimos commented Jan 31, 2020 •
edited
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 31, 2020 •
edited
Loading

No bundle size changes comparing 5f990d4...ff7f266

Generated by 🚫 dangerJS against ff7f266

oliviertassinari
oliviertassinari reviewed Jan 31, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project looks cool, thanks for sharing. Regarding the preview image, could you reduce it weitgh to around 100 kB? Also make sure the dimensions are identical to the other previews :).

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 31, 2020
@oliviertassinari oliviertassinari changed the title cinemaPlus added to showcase [docs] Add cinemaPlus to showcase Jan 31, 2020
@georgesimos
Copy link
Contributor Author

Hi Olivier,
Dimensions are identical to other previews.
And I am going to reduce the size.

@oliviertassinari oliviertassinari merged commit df41fc7 into mui:master Feb 1, 2020
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@georgesimos @EsoterikStare
[docs] Add cinemaPlus to showcase (mui#19502)
2a04be2
This was referenced Feb 25, 2020
Closed
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Open
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mbrookes mbrookes mbrookes approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgesimos @mui-pr-bot @mbrookes @oliviertassinari