-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Divider] Fix height for vertical divider in a flexbox #19614
Conversation
Details of bundle changes.Comparing: 5794780...d4d91fa
|
@oliviertassinari It works, but in this case |
2e14fd6
to
d91bbab
Compare
I have checked argos-ci, it is looks Ok, except |
@captain-yossarian Thanks |
@@ -36,5 +36,6 @@ The examples below show two ways of achieving this. | |||
## Vertical Dividers | |||
|
|||
You can also render a divider vertically using the `orientation` prop. | |||
Note the usage of the `flexItem` prop to accommodate for the flex container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the usage of the `flexItem` prop to accommodate for the flex container. | |
Note the use of the `flexItem` prop to accommodate for the flex container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I take care of it in a follow-up.
@@ -99,7 +99,7 @@ Divider.propTypes = { | |||
*/ | |||
component: PropTypes.elementType, | |||
/** | |||
* If `true`, the divider will apply different strategy for height. | |||
* If `true`, the divider will apply adapt to a parent flex container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* If `true`, the divider will apply adapt to a parent flex container. | |
If `true`, the divider will adapt to a parent flex container. |
?
(Fixes the grammar, but it's still not clear what this is actually trying to say.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how we could better explain the role of this prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could spell it out 🤷♂:
* If `true`, the divider will apply adapt to a parent flex container. | |
If `true`, a vertical divider will have the correct height when used in flex container. (By default, a vertical divider will have a calculated height of `0px` in Chrome if it is the child of a flex container.) |
Closes #18022