-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix a few WAVE errors #20304
Merged
oliviertassinari
merged 6 commits into
mui:master
from
oliviertassinari:fix-wave-errors
Mar 27, 2020
Merged
[docs] Fix a few WAVE errors #20304
oliviertassinari
merged 6 commits into
mui:master
from
oliviertassinari:fix-wave-errors
Mar 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 51f16ae...323dce3 Details of page changes
|
oliviertassinari
changed the title
[docs] Fix a few wave errors
[docs] Fix a few WAVE errors
Mar 27, 2020
eps1lon
reviewed
Mar 27, 2020
@@ -21,7 +20,7 @@ export default function GroupedSelect() { | |||
<div> | |||
<FormControl className={classes.formControl}> | |||
<InputLabel htmlFor="grouped-native-select">Grouping</InputLabel> | |||
<Select native defaultValue="" input={<Input id="grouped-native-select" />}> | |||
<Select native defaultValue="" id="grouped-native-select"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice: https://github.com/eps1lon/mui-scripts-incubator/pull/104/files#diff-056b38a9627a5a625683edca923daa75R397 (diff shows that the label is now correctly applied to the combobox. before that it didn't have one)
eps1lon
approved these changes
Mar 27, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple if errors reported by WAVE. Related to #20296.