[core] Fix incorrect typings regarding transition components and chilren #20306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Mar 27, 2020
| @@ -8,7 +8,10 @@ import DialogTitle from '@material-ui/core/DialogTitle'; | |||
| import Slide from '@material-ui/core/Slide'; | |||
| import { TransitionProps } from '@material-ui/core/transitions'; | |||
|
|
|||
| const Transition = React.forwardRef<unknown, TransitionProps>(function Transition(props, ref) { | |||
| const Transition = React.forwardRef(function Transition( | |||
| props: TransitionProps & { children?: React.ReactElement<any, any> }, | |||
There was a problem hiding this comment.
Was previously implicitly children?: React.ReactNode
Details of bundle changes.Comparing: d956b40...0ed8aff Details of page changes
|
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors in typescript 3.9-beta reported in test_types_next
We were previously relying on implicit children types (from FunctionComponent and ForwardRefComponent) and the false assumption that every transition component implements the same
childrentype. Now that our TS types follow closely our (runtime) propTypes the issue was more obvious but typescript < 3.9 did not catch these.