Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Batch small changes #20312

Merged
merged 6 commits into from
Mar 28, 2020
Merged

[docs] Batch small changes #20312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff937c0
[blog] Use dedicated class name
oliviertassinari Mar 28, 2020
1bb3958
[docs] Fix leaking prop on DOM node
oliviertassinari Mar 28, 2020
e320f46
[docs] Increase spacing to help readability
oliviertassinari Mar 28, 2020
16d38b9
[docs] Fix Duplicate ID demo-null
oliviertassinari Mar 28, 2020
445361d
[docs] Fix Duplicate ID limit-tags
oliviertassinari Mar 28, 2020
1460f3c
closer logic to what we do in the core components with setDefaultId
oliviertassinari Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/pages/blog/2019-developer-survey-results.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,4 +320,4 @@ We will run a similar survey next year to keep track of our progress.
If you want to continue to influence our roadmap, please upvote 👍 the issues you are the most interested in on GitHub.

<img src="/static/blog/2019-survey/vote.gif" style="display: block; margin: 0 auto;" alt="How to upvote on GitHub" />
<div style="font-style: italic; text-align: center; margin: 8px;">Help us prioritize by upvoting.</div>
<p class="blog-description">Help us prioritize by upvoting.</p>
4 changes: 2 additions & 2 deletions docs/src/modules/components/AppContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ const useStyles = makeStyles((theme) => ({
root: {
paddingTop: 80 + 16,
[theme.breakpoints.up('lg')]: {
paddingLeft: theme.spacing(5),
paddingRight: theme.spacing(5),
paddingLeft: theme.spacing(6),
paddingRight: theme.spacing(6),
},
},
}));
Expand Down
6 changes: 3 additions & 3 deletions docs/src/modules/components/Demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,12 @@ function getDemoData(codeVariant, demo, githubLocation) {
// TODO: replace with React.useOpaqueReference if it is released
function useUniqueId(prefix) {
// useOpaqueReference
const [id, setDemoId] = React.useState(null);
const [id, setId] = React.useState();
React.useEffect(() => {
setDemoId(Math.random().toString(36).slice(2));
setId(Math.random().toString(36).slice(2));
}, []);

return `${prefix}${id}`;
return id ? `${prefix}${id}` : id;
}

function Demo(props) {
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/autocomplete/LimitTags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function LimitTags() {
<Autocomplete
multiple
limitTags={2}
id="limit-tags"
id="multiple-limit-tags"
options={top100Films}
getOptionLabel={(option) => option.title}
defaultValue={[top100Films[13], top100Films[12], top100Films[11]]}
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/autocomplete/LimitTags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default function LimitTags() {
<Autocomplete
multiple
limitTags={2}
id="limit-tags"
id="multiple-limit-tags"
options={top100Films}
getOptionLabel={(option) => option.title}
defaultValue={[top100Films[13], top100Films[12], top100Films[11]]}
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/landing/Steps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function HomeSteps() {
const t = useSelector((state) => state.options.t);

return (
<Container disableGutters maxwidth="lg" className={classes.root}>
<Container disableGutters className={classes.root}>
<Grid container>
<Grid item xs={12} md={6} className={clsx(classes.step, classes.leftStep)}>
<div className={classes.stepTitle}>
Expand Down