-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Use .checkPropTypes instead of render + propTypes #20451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: e751e90...9265f8c Details of page changes
|
Otherwise tests could work without resetWarningCache because another test ran before them that reset the cache
eps1lon
force-pushed
the
test/checkPropTypes
branch
from
April 7, 2020 08:29
4a38177
to
9265f8c
Compare
oliviertassinari
approved these changes
Apr 7, 2020
This was referenced Apr 13, 2020
This was referenced Apr 20, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropTypes.resetWarningCache
will no longer reset the same cache that react is using in the next minor. However, it will reset the same cache thatPropTypes.checkPropTypes
is using.More context: facebook/react#18251
Includes a refactor where we move cache clearing to beforeEach from afterEach. This makes it less likely to hide missing resets.
@gaearon Interesting diff in 9265f8c. Custom validators: