Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextareaAutosize] Fix height inconsistency for empty last row #20575

Merged
merged 2 commits into from
Apr 16, 2020
Merged

[TextareaAutosize] Fix height inconsistency for empty last row #20575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04a2d92
[TextareaAutosize] Fix height inconsistency for empty last row
benwiley4000 Apr 15, 2020
a1ee887
Update TextareaAutosize.js
oliviertassinari Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/material-ui/src/TextareaAutosize/TextareaAutosize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ const TextareaAutosize = React.forwardRef(function TextareaAutosize(props, ref)
const inputShallow = shadowRef.current;
inputShallow.style.width = computedStyle.width;
inputShallow.value = input.value || props.placeholder || 'x';
if (inputShallow.value.slice(-1) === '\n') {
// Certain fonts which overflow the line height will cause the textarea
// to report a different scrollHeight depending on whether the last line
// is empty. Make it non-empty to avoid this issue.
inputShallow.value += ' ';
}

const boxSizing = computedStyle['box-sizing'];
const padding =
Expand Down