Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Support Cascading Menus #20591

Closed
wants to merge 13 commits into from
Closed

[Menu] Support Cascading Menus #20591

wants to merge 13 commits into from

Commits on Nov 15, 2021

  1. Cascading Menu initial work and review refactoring 

    Fix menu test


Run Prettier


Update proptypes


Update api docs


Remove d.ts comments to prevent internal api from entering the docs


Add handleParentClose to types and propTypes


Refactor away from old ref pattern


Remove useless key reference


Create SubMenu component to remove open prop from type


Rebase on latest next branch and update props API accordingly


Run `yarn proptypes` to update MenuItem


Clean up demo, per discussion


Get handler name in line with convention


Comment problematic tests temporarily; Address test setup issue


Add api docs for SubMenu


Remove disused imports from CascadingMenu demo


Update api of Menu, MenuItem, and SubMenu


Add superficial test stub for SubMenu


Rename prop to match rename of handleParentClose to onParentClose


Run yarn prettier


Troubleshoot Menu test failure in CI


Revert Menu test troubleshooting changes


Refactor away from event.stopPropagation


Refactor away from Object.assign in Menu item clone block


Remove eslint ignore consistent return and fix issue in Menu item clone block 


Remove memoization in Menu and run prettier


Fix most of the Cascading Menu tests


Run yarn prettier


Run `yarn docs:api` after rebase


Fix Menu test issues around beforeEach and afterEach mounting


Update CascadingMenu tests setup to use SubMenu component


Commit docs:api result


Update .eslintrc.js to allow chai chainable getters


Migrate all Cascading Menu tests from assert to expect


Commit `yarn prettier` result


Revert change to eslint to support chai chainable getters


Update Menu tests to use .to.equal() instead of .to.be


Fix line ending issue with docs:api
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    ce8576a View commit details
    Browse the repository at this point in the history

  2. Refactor Cascading Menu tests to use RTL instead of Enzyme 

    Update MenuItem api docs and fix a doc typo


Format Menu tests with yarn prettier


Wrap all Menu test fireEvents in act()
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    63a05f6 View commit details
    Browse the repository at this point in the history

  3. Fixed left arrow regression 

    Re-enable test for keyboard focus regression, now that it's fixed
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    741b6cc View commit details
    Browse the repository at this point in the history

  4. Make parent items of open sub menus stay hightlighted 

    Add test for open sub menu parent highlighting


Modify imperative focus management to work with highlighting logic


Fix and add some documentation comments, prettier, duplicate line cleanup


Update docs:api
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    5443dff View commit details
    Browse the repository at this point in the history

  5. First stab at trying to fix Menu tests after refactor to RTL 

    Trying to get Menu tests to pass


Formatting and docs


About half way refactored; Hit the first snag


Few more tests refactored; Some tests are not working;


Getting the tests to pass

Update @testing-library/dom to v7.28.1


Move all clock.restore() calls above final assertions



Remove demo changes


Bumping timeout on delayed assertions to reduce chance of failure


Remove artifactory location from lock file... (no idea how this happened)


Remove orphaned waitFor import
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    a8c987b View commit details
    Browse the repository at this point in the history

  6. Get tests fully working again 

    Updated arrow up/down tests

Reverted last fix, commented out problematic tests

Updated tab test

Updated escape keydown test

Uncommented out last async test, brought back old testing script

Updating tests to pass karma and unit tests a few at a time

Uncommented all tests, added transition delays for better test performance

Removed unnecessary transition duration additions

Fixed copy/paste issue in package.json, removed unused import in tests

Formatting new test changes with prettier


Adding hidden flag to menu test query to grab elements hidden by opened popover

Added more hidden flags to tests

Committing prettier changes

Added another hidden flag for button
    Anthony Paradowski authored and Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    b0ffe95 View commit details
    Browse the repository at this point in the history

  7. Get MenuItem fully working and looking good after emotion changes

    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    2dfdd8d View commit details
    Browse the repository at this point in the history

  8. Clean up weird, unnecessary branch in Menu and a couple other fixes 

    Add theme.direction to PropTypes to make linter happy


prettier


Remove console
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    14db48e View commit details
    Browse the repository at this point in the history

  9. Update failing test

    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    6cd2558 View commit details
    Browse the repository at this point in the history

  10. conform clock usage and drop find* queries

    @eps1lon
    eps1lon authored and Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    bd0e5be View commit details
    Browse the repository at this point in the history

  11. Comment failing assertion and add comments about desired focus approach

    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    c601269 View commit details
    Browse the repository at this point in the history

  12. More fixes and cleanup after emotion changes 

    Fix ref to get child menus to render


Partial fix for pointer event control


Fix submenu pointerEvents staying off; CascadingMenus functional now


Remove disused darkMode switching from CascadingMenus demo


Transition MenuItem to be more similar to next code and cleanup


Run prettier and docs:api scripts


Clean up old focus management code and notes that are no longer relevant


Remove useless key prop assignment


Clean up MenuList onKeyDown function call


Refactor makeStyles usage in MenuItem to use theme from provider


Fix `should pass onClose prop to Popover` menu test


Fix missing unique key prop react warning that was blowing up most tests 


Minor fixes to test setup


Fix a couple more tests, revert change that actually breaks functionality


Make it so that onClose only fires once, fixing the last failing Menu test



Move makeStyles/classNames usage off MenuItem root to fix tests


Run prettier and docs:api


Fix the actual problem and revert test changes


Finish fixing arrow left right test


Remove duplicate type export


Cleanup rebase badness


Fix a few linting issues
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    1957dd5 View commit details
    Browse the repository at this point in the history

  13. Migrate CascadingMenu changes to new @mui paradigm 

    Migrate MenuItem changes


Migrating SubMenu addition




Migrating MenuList changes


Remove files from old path after migration


Fix a couple of missed migration things


Update docs:api


Update Cascading Menu demo to new imports


Update submenu import path


linting-fix
    Erik Burton committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    1dfee12 View commit details
    Browse the repository at this point in the history