-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppBar] Migrate to testing-library #20693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosvega91
changed the title
[AppBar] using test-library
[AppBar] using testing-library
Apr 22, 2020
oliviertassinari
approved these changes
Apr 22, 2020
Details of bundle changes.Comparing: 39063ab...a0a870d Details of page changes
|
oliviertassinari
changed the title
[AppBar] using testing-library
[AppBar] Migrate to testing-library
Apr 22, 2020
oliviertassinari
added
component: app bar
This is the name of the generic UI component, not the React module!
test
labels
Apr 22, 2020
@marcosvega91 Very cool, thanks! |
I think that i will refactor other components. Is better to open a single PR or open multiple PR for each component? |
@marcosvega91 I think that above 300 LOCs, we can start to wonder if the pull request can be broken down. |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it's good or not but I started refactoring tests using testing library