[TextField] Fix required outlined label space with no asterisk #20715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Details of bundle changes.Comparing: 79a29f5...e442877 Details of page changes
|
| @@ -107,10 +107,11 @@ const TextField = React.forwardRef(function TextField(props, ref) { | |||
| InputMore.notched = InputLabelProps.shrink; | |||
| } | |||
| if (label) { | |||
| const displayRequired = InputLabelProps?.required ?? required; | |||
There was a problem hiding this comment.
This line transforms into:
var _InputLabelProps$requ, _InputLabelProps;
var displayRequired = (_InputLabelProps$requ = (_InputLabelProps = InputLabelProps) === null ||
_InputLabelProps === void 0 ? void 0 : _InputLabelProps.required) !== null
&& _InputLabelProps$requ !== void 0 ? _InputLabelProps$requ : required;What do you think of?
Suggested change
| const displayRequired = InputLabelProps?.required ?? required; | |
| const displayRequired = InputLabelProps && InputLabelProps.required != null ? required : undefined; |
There was a problem hiding this comment.
Let's stick with the correct semantics and improve transpiling with modern bundles.
There was a problem hiding this comment.
I wonder about the tradeoff:
- cost: what's the broader impact if we fully scale-out this syntax? +X% bundle size impact, will X be negligible? I wonder about why the transpiled code tests for strict equality with undefined and null vs
!= null. Maybe Babel can/will optimize it. I hope it won't, at scale, have the same overhead has theclasssyntax. - value: what cases does the new syntax allow us to better cover?
There was a problem hiding this comment.
what's the broader impact if we fully scale-out this syntax?
Valid point. But we need to be careful that we don't fall into worrying about things we don't need (see "yagni").
I'm looking through all our plugins and see if we can safely enable loose mode in preset-env. For only these two syntaxes babel/babel#6978 would help.
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
approved these changes
Apr 23, 2020
This was referenced Apr 29, 2020
2 tasks
CarsonF
added a commit
to SeedCompany/cord-field
that referenced
this pull request
Apr 30, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20705
Fix verified in https://codesandbox.io/s/asterisk-material-ui-4911-uheri