Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix popup open logic when non empty #20732

Merged
merged 5 commits into from
Apr 24, 2020
Merged

[Autocomplete] Fix popup open logic when non empty #20732

merged 5 commits into from
Apr 24, 2020

Commits on Apr 24, 2020

  1. [Autocomplete] Add test case to see the problem

    @marcosvega91
    marcosvega91 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    562c078 View commit details
    Browse the repository at this point in the history

  2. [Autocomplete] Open popup when the input has already a value

    @marcosvega91
    marcosvega91 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    898976e View commit details
    Browse the repository at this point in the history

  3. [Autocomplete] Change behavior of mouseDown event and add new test case 

    The text box inside Autocomplete component responds to click event.
If the text box is empty it will toggle the list box.
If the text box is not empty it will only open the list box.
    @marcosvega91
    marcosvega91 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    e1a6a03 View commit details
    Browse the repository at this point in the history

  4. update tests

    @oliviertassinari
    oliviertassinari committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    0ee9f80 View commit details
    Browse the repository at this point in the history

  5. remove duplicate test case

    @oliviertassinari
    oliviertassinari committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    6815a59 View commit details
    Browse the repository at this point in the history