-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Document how far Material-UI should go #20737
[l10n] Document how far Material-UI should go #20737
Conversation
Details of bundle changes.Comparing: 21d01a5...6fd2486 Details of page changes
|
@eloyrubinos Thanks for the contribution, this raises an interesting concern, at some point, we will need to reject languages that aren't spoken enough. Looking at the top 100 most spoken languages, galician could be within the 500-200 range popularity. |
I hadn't thought about that, honestly, but it is a legitimate concern. Feel free to reject the PR. |
@eloyrubinos I'm sorry, I think that we should close, we support 31 locales, it would be better to focus on the 50 to 100 top most popular ones: https://en.wikipedia.org/wiki/List_of_languages_by_number_of_native_speakers. After that, I think that the opportunity cost will be too high. |
Actually, let's document it. |
I have given it some more thought and I don't know that it would be so bad to support "too many" locales. After all the piece to translate is very small. What would be the drawbacks? |
@eloyrubinos Supporting, say the top 200 locales vs the top 100 means
Now, I'm only assuming that gl-ES is in the top 200, what's if it's in the top 400 instead? |
I hadn't thought about points 2 and 3. That's why you are the reviewer and I'm the "reviewee" 😄 |
jQuery UI has ~70 locales, moment has ~120 locales. |
I count ~700 locales in http://www.localeplanet.com/icu/index.html. |
ea566e9
to
8e1fb5c
Compare
Interestingly, if we cut at 100 locales, it seems that we cover ~85% of the world population for native speakers only, assuming people talk multiple languages, it should allow us to over a higher percentage. https://en.wikipedia.org/wiki/List_of_languages_by_number_of_native_speakers |
@eloyrubinos Thanks for initiating this discussion :) |
I landed here by reading the last changelog. Just one question @oliviertassinari: how complex would it be to let the consuming app provide this kind of not common translations? It feels a bit sad to say we don't want to support not popular enough languages and not provide any workaround. Please note, that I completely agree with the reasons why this kind of translations are not directly supported by MUI. 🙂 |
How did you come to this conclusion? |
I came to it by only looking at the changes in this PR. Sorry if my comment sounded aggressive. 🙏 After looking at the documentation (https://material-ui.com/guides/localization/), I now realize that it was already possible to provide custom translations. 🙈 BTW the "You can find the source" link is broken on this page. |
@ValentinH Thanks, do you want to patch the link? :) we are on a |
Hi! @ValentinH as you say that links provides the info you wanted but I wanted to drop in and let you know that it is actually pretty easy to implement a hybrid solution, which is the direction I took in the aforementioned project that needed the galician translation. That is because I want to benefit from any and all future changes to the officially supported locales without my needing to manually update a local file. The "workaround" though a bit verbose is quite simple. I map a list of languages with information about whether they exist in MUI or must be loaded locally. A simplified excerpt for this would be:
I put this together pretty quick and includes support for dynamic locale which wasn't the point of this topic so don't take it at face value but I think you get the idea. Hope this helps you in any way. See you! :) |
I need MUI galician-localized for a project and I though of contributing the translations, so here they are.