Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] Migrate to testing-library #20773

Merged
merged 6 commits into from
Apr 26, 2020
Merged

[Card] Migrate to testing-library #20773

merged 6 commits into from
Apr 26, 2020

Commits on Apr 26, 2020

  1. [Card] migrate to testing-library

    @marcosvega91
    marcosvega91 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    3897911 View commit details
    Browse the repository at this point in the history

  2. [CardHeader] migrate to testing-library

    @marcosvega91
    marcosvega91 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    dd3789b View commit details
    Browse the repository at this point in the history

  3. [CardMedia] migrate to testing-library

    @marcosvega91
    marcosvega91 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    70d2bee View commit details
    Browse the repository at this point in the history

  4. run prettier and linter

    @marcosvega91
    marcosvega91 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    e9c8e60 View commit details
    Browse the repository at this point in the history

  5. [CardMedia] use match instead of equal for style props

    @marcosvega91
    marcosvega91 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    dbab7b9 View commit details
    Browse the repository at this point in the history

  6. [CardMedia] change reg expr to check background-image 

    Because of tests are run on multiple browser is better to check only if the images are the same and not all the value
In local the value is url(foo.jpg)
In chrome the value is url("foo.jpg")
In safari the value is url(localhost:111/foo.jpg)
    @marcosvega91
    marcosvega91 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    6184297 View commit details
    Browse the repository at this point in the history