Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Batch small changes #20980

Merged
merged 13 commits into from
May 11, 2020
Merged

[core] Batch small changes #20980

merged 13 commits into from
May 11, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 10, 2020 •
edited
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented May 10, 2020 •
edited
Loading

Details of bundle changes.

Comparing: d74bd5d...656f0b8

Details of page changes
bundle Size Change Size Gzip Change Gzip
/components/skeleton ▲ +100 B (+0.99% ) 10.2 kB -- -1 B
/customization/density ▲ +10 B (+0.10% ) 9.76 kB -- -1 B
/discover-more/backers ▲ +10 B (+0.33% ) 3.05 kB -- -1 B
/discover-more/team ▲ +10 B (+0.15% ) 6.68 kB -- -1 B
/getting-started/templates ▲ +10 B (+0.11% ) 8.92 kB -- -1 B
/getting-started/templates/blog ▲ +10 B (+0.13% ) 7.45 kB -- -1 B
/getting-started/templates/dashboard ▲ +10 B (+0.11% ) 8.87 kB -- -1 B
/getting-started/templates/sign-in-side ▲ +10 B (+0.11% ) 9.3 kB -- -1 B
/getting-started/templates/sign-in ▲ +10 B (+0.10% ) 9.54 kB -- -1 B
/premium-themes/onepirate/forgot-password ▼ -10 B (-0.99% ) 1 kB -- -1 B
/system/shadows ▲ +10 B (+0.26% ) 3.86 kB -- -1 B
/_app -- 37.2 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.61 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.86 kB -- -1 B
/api-docs/backdrop -- 1.72 kB -- -1 B
/api-docs/badge -- 2.13 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.84 kB -- -1 B
/api-docs/button-base -- 2.33 kB -- -1 B
/api-docs/button-group -- 2.23 kB -- -1 B
/api-docs/button -- 2.56 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.07 kB -- -1 B
/api-docs/click-away-listener -- 1.37 kB -- -1 B
/api-docs/collapse -- 2.13 kB -- -1 B
/api-docs/container -- 1.86 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.73 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.49 kB -- -1 B
/api-docs/expansion-panel-details -- 1.41 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.72 kB -- -1 B
/api-docs/expansion-panel -- 1.97 kB -- -1 B
/api-docs/fab -- 2.11 kB -- -1 B
/api-docs/fade -- 1.5 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.98 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.8 kB -- -1 B
/api-docs/grid-list-tile -- 1.72 kB -- -1 B
/api-docs/grid-list -- 1.62 kB -- -1 B
/api-docs/grid -- 2.56 kB -- -1 B
/api-docs/grow -- 1.55 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.1 kB -- -1 B
/api-docs/icon -- 1.78 kB -- -1 B
/api-docs/input-adornment -- 1.93 kB -- -1 B
/api-docs/input-base -- 2.95 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.93 kB -- -1 B
/api-docs/list-item-avatar -- 1.5 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.77 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/menu -- 2.4 kB -- -1 B
/api-docs/mobile-stepper -- 1.93 kB -- -1 B
/api-docs/modal -- 2.42 kB -- -1 B
/api-docs/native-select -- 2.08 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/outlined-input -- 2.98 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.24 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popover -- 2.69 kB -- -1 B
/api-docs/popper -- 1.91 kB -- -1 B
/api-docs/portal -- 1.34 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.41 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.94 kB -- -1 B
/api-docs/skeleton -- 1.77 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.71 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.3 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.26 kB -- -1 B
/api-docs/swipeable-drawer -- 2 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-context -- 1.05 kB -- -1 B
/api-docs/tab-list -- 1.08 kB -- -1 B
/api-docs/tab-panel -- 1.45 kB -- -1 B
/api-docs/tab-scroll-button -- 1.61 kB -- -1 B
/api-docs/tab -- 1.99 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.13 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.46 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.68 kB -- -1 B
/api-docs/tabs -- 2.61 kB -- -1 B
/api-docs/text-field -- 3.18 kB -- -1 B
/api-docs/textarea-autosize -- 1.13 kB -- -1 B
/api-docs/toggle-button-group -- 1.81 kB -- -1 B
/api-docs/toggle-button -- 1.8 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.54 kB -- -1 B
/api-docs/tree-item -- 1.88 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/api-docs/zoom -- 1.52 kB -- -1 B
/blog/2019-developer-survey-results -- 6.36 kB -- -1 B
/blog/2019 -- 4.24 kB -- -1 B
/blog/2020-introducing-sketch -- 3.5 kB -- -1 B
/blog/2020-q1-update -- 4.33 kB -- -1 B
/blog/april-2019-update -- 3.13 kB -- -1 B
/blog/august-2019-update -- 2.24 kB -- -1 B
/blog/december-2019-update -- 2.37 kB -- -1 B
/blog/july-2019-update -- 2.13 kB -- -1 B
/blog/june-2019-update -- 2.01 kB -- -1 B
/blog/march-2019-update -- 2.54 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.67 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.68 kB -- -1 B
/blog/may-2019-update -- 2.35 kB -- -1 B
/blog/november-2019-update -- 2.75 kB -- -1 B
/blog/october-2019-update -- 2.5 kB -- -1 B
/blog/september-2019-update -- 2.68 kB -- -1 B
/company/about -- 1.74 kB -- -1 B
/company/contact -- 1.33 kB -- -1 B
/company/jobs -- 1.35 kB -- -1 B
/components/about-the-lab -- 6.8 kB -- -1 B
/components/alert -- 12.9 kB -- -1 B
/components/app-bar -- 30.2 kB -- -1 B
/components/autocomplete -- 100 kB -- -1 B
/components/avatars -- 9.16 kB -- -1 B
/components/backdrop -- 2.68 kB -- -1 B
/components/badges -- 15.5 kB -- -1 B
/components/bottom-navigation -- 6.27 kB -- -1 B
/components/box -- 8.05 kB -- -1 B
/components/breadcrumbs -- 14.7 kB -- -1 B
/components/button-group -- 7.43 kB -- -1 B
/components/buttons -- 26.2 kB -- -1 B
/components/cards -- 17.3 kB -- -1 B
/components/checkboxes -- 16.3 kB -- -1 B
/components/chips -- 21.8 kB -- -1 B
/components/click-away-listener -- 4.58 kB -- -1 B
/components/container -- 3.72 kB -- -1 B
/components/css-baseline -- 6.74 kB -- -1 B
/components/dialogs -- 42.8 kB -- -1 B
/components/dividers -- 12.8 kB -- -1 B
/components/drawers -- 31.5 kB -- -1 B
/components/expansion-panels -- 20.7 kB -- -1 B
/components/floating-action-button -- 10.6 kB -- -1 B
/components/grid-list -- 12.1 kB -- -1 B
/components/grid -- 32.4 kB -- -1 B
/components/hidden -- 10.6 kB -- -1 B
/components/icons -- 27.3 kB -- -1 B
/components/links -- 6.91 kB -- -1 B
/components/lists -- 26.7 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 24.9 kB -- -1 B
/components/modal -- 11.9 kB -- -1 B
/components/no-ssr -- 5.11 kB -- -1 B
/components/pagination -- 9.45 kB -- -1 B
/components/paper -- 3.49 kB -- -1 B
/components/pickers -- 6 kB -- -1 B
/components/popover -- 17.4 kB -- -1 B
/components/popper -- 23.4 kB -- -1 B
/components/portal -- 3 kB -- -1 B
/components/progress -- 20.3 kB -- -1 B
/components/radio-buttons -- 14.8 kB -- -1 B
/components/rating -- 10.8 kB -- -1 B
/components/selects -- 31.2 kB -- -1 B
/components/slider -- 15.6 kB -- -1 B
/components/snackbars -- 27.8 kB -- -1 B
/components/speed-dial -- 14.6 kB -- -1 B
/components/steppers -- 36.6 kB -- -1 B
/components/switches -- 16.4 kB -- -1 B
/components/tables -- 143 kB -- -1 B
/components/tabs -- 21.4 kB -- -1 B
/components/text-fields -- 54.8 kB -- -1 B
/components/textarea-autosize -- 2.94 kB -- -1 B
/components/toggle-button -- 10.5 kB -- -1 B
/components/tooltips -- 17 kB -- -1 B
/components/transfer-list -- 9.68 kB -- -1 B
/components/transitions -- 12.1 kB -- -1 B
/components/tree-view -- 11.2 kB -- -1 B
/components/typography -- 9.92 kB -- -1 B
/components/use-media-query -- 12.9 kB -- -1 B
/customization/breakpoints -- 16 kB -- -1 B
/customization/color -- 20.9 kB -- -1 B
/customization/components -- 38.4 kB -- -1 B
/customization/default-theme -- 8.8 kB -- -1 B
/customization/globals -- 4.72 kB -- -1 B
/customization/palette -- 14.1 kB -- -1 B
/customization/spacing -- 2.61 kB -- -1 B
/customization/theming -- 18.7 kB -- -1 B
/customization/typography -- 11.8 kB -- -1 B
/customization/z-index -- 3.13 kB -- -1 B
/discover-more/changelog -- 1.44 kB -- -1 B
/discover-more/languages -- 3.44 kB -- -1 B
/discover-more/related-projects -- 7.96 kB -- -1 B
/discover-more/roadmap -- 3.72 kB -- -1 B
/discover-more/showcase -- 13.4 kB -- -1 B
/discover-more/vision -- 6.68 kB -- -1 B
/getting-started/example-projects -- 6.94 kB -- -1 B
/getting-started/faq -- 36.2 kB -- -1 B
/getting-started/installation -- 7.83 kB -- -1 B
/getting-started/learn -- 8.98 kB -- -1 B
/getting-started/support -- 9.15 kB -- -1 B
/getting-started/supported-components -- 6.7 kB -- -1 B
/getting-started/supported-platforms -- 5.84 kB -- -1 B
/getting-started/templates/album -- 5.59 kB -- -1 B
/getting-started/templates/checkout -- 11.2 kB -- -1 B
/getting-started/templates/pricing -- 7.8 kB -- -1 B
/getting-started/templates/sign-up -- 9.64 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.58 kB -- -1 B
/guides/api -- 15.8 kB -- -1 B
/guides/composition -- 14.9 kB -- -1 B
/guides/flow -- 2.26 kB -- -1 B
/guides/interoperability -- 16.3 kB -- -1 B
/guides/localization -- 11.8 kB -- -1 B
/guides/migration-v0x -- 7.39 kB -- -1 B
/guides/migration-v3 -- 19.2 kB -- -1 B
/guides/minimizing-bundle-size -- 8.7 kB -- -1 B
/guides/responsive-ui -- 4.27 kB -- -1 B
/guides/right-to-left -- 6.77 kB -- -1 B
/guides/server-rendering -- 8.75 kB -- -1 B
/guides/testing -- 8.61 kB -- -1 B
/guides/typescript -- 15.1 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 8.5 kB -- -1 B
/performance/table-hook -- 2.24 kB -- -1 B
/performance/table-mui -- 4.49 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.6 kB -- -1 B
/premium-themes/onepirate -- 7.32 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 8.96 kB -- -1 B
/styles/advanced -- 33.3 kB -- -1 B
/styles/api -- 16.9 kB -- -1 B
/styles/basics -- 16.5 kB -- -1 B
/system/api -- 5.96 kB -- -1 B
/system/basics -- 27.4 kB -- -1 B
/system/borders -- 4.1 kB -- -1 B
/system/display -- 6.55 kB -- -1 B
/system/flexbox -- 5.85 kB -- -1 B
/system/palette -- 4.35 kB -- -1 B
/system/positions -- 2.53 kB -- -1 B
/system/sizing -- 3.53 kB -- -1 B
/system/spacing -- 6.01 kB -- -1 B
/system/typography -- 4.41 kB -- -1 B
/versions -- 23.7 kB -- -1 B
docs:chunk:shared -- 61.7 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
useAutocomplete ▼ -569 B (-3.79% ) 14.5 kB ▼ -92 B (-1.74% ) 5.18 kB
@material-ui/lab ▼ -163 B (-0.08% ) 217 kB ▼ -58 B (-0.09% ) 64.7 kB
TreeView ▼ -105 B (-0.14% ) 73.3 kB ▼ -30 B (-0.13% ) 23.1 kB
@material-ui/core ▼ -50 B (-0.01% ) 371 kB ▲ +15 B (+0.01% ) 102 kB
ToggleButtonGroup ▼ -31 B (-0.05% ) 67.7 kB ▼ -21 B (-0.10% ) 21.3 kB
Autocomplete ▼ -27 B (-0.02% ) 136 kB ▲ +10 B (+0.02% ) 42.9 kB
TablePagination ▼ -19 B (-0.01% ) 148 kB ▼ -9 B (-0.02% ) 43.8 kB
TextField ▼ -17 B (-0.01% ) 131 kB ▼ -28 B (-0.07% ) 38.5 kB
Select ▼ -17 B (-0.01% ) 122 kB ▼ -23 B (-0.06% ) 36.4 kB
Hidden ▼ -13 B (-0.02% ) 70.9 kB ▼ -17 B (-0.08% ) 22.3 kB
Slider ▼ -10 B (-0.01% ) 80.9 kB -- 25.9 kB
MobileStepper ▼ -8 B (-0.01% ) 72.7 kB ▼ -3 B (-0.01% ) 22.9 kB
LinearProgress ▼ -8 B (-0.01% ) 70.2 kB -- 21.8 kB
@material-ui/core[umd] ▲ +6 B (0.00% ) 326 kB ▲ +2 B (0.00% ) 95 kB
TableCell ▼ -2 B (-0.00% ) 69 kB ▼ -4 B (-0.02% ) 21.7 kB
Badge -- 70.2 kB ▼ -77 B (-0.35% ) 21.9 kB
NativeSelect -- 81.9 kB ▼ -77 B (-0.30% ) 25.9 kB
Grid -- 70 kB ▼ -74 B (-0.34% ) 22 kB
Checkbox -- 86.7 kB ▼ -67 B (-0.24% ) 27.4 kB
Radio -- 87.7 kB ▼ -66 B (-0.24% ) 27.8 kB
Switch -- 85.9 kB ▼ -65 B (-0.24% ) 27 kB
ExpansionPanelSummary -- 82.6 kB ▼ -60 B (-0.23% ) 26.2 kB
SpeedDialAction -- 123 kB ▼ -23 B (-0.06% ) 39.3 kB
TreeItem -- 80.9 kB ▼ -11 B (-0.04% ) 25.8 kB
Alert -- 87.8 kB ▲ +8 B (+0.03% ) 27.8 kB
ToggleButton -- 80.6 kB ▼ -6 B (-0.02% ) 25.6 kB
ButtonBase -- 78.5 kB ▼ -5 B (-0.02% ) 24.7 kB
ButtonGroup -- 87.9 kB ▼ -5 B (-0.02% ) 27.2 kB
Dialog -- 88.7 kB ▲ +5 B (+0.02% ) 27.9 kB
Drawer -- 90.8 kB ▼ -5 B (-0.02% ) 27.7 kB
@material-ui/styles -- 52.1 kB ▼ -4 B (-0.03% ) 15.6 kB
AppBar -- 68.9 kB ▼ -4 B (-0.02% ) 21.6 kB
Backdrop -- 73.6 kB ▼ -4 B (-0.02% ) 22.8 kB
Button -- 84.2 kB ▼ -4 B (-0.02% ) 25.9 kB
CardHeader -- 69.9 kB ▼ -4 B (-0.02% ) 22.1 kB
Chip -- 87.2 kB ▼ -4 B (-0.01% ) 26.8 kB
Collapse -- 74 kB ▼ -4 B (-0.02% ) 22.9 kB
Container -- 68.1 kB ▼ -4 B (-0.02% ) 21.3 kB
CssBaseline -- 66.9 kB ▼ -4 B (-0.02% ) 21 kB
DialogTitle -- 69.2 kB ▼ -4 B (-0.02% ) 21.8 kB
ExpansionPanel -- 77.5 kB ▼ -4 B (-0.02% ) 24.5 kB
Fab -- 81.3 kB ▼ -4 B (-0.02% ) 25.4 kB
FilledInput -- 78.7 kB ▼ -4 B (-0.02% ) 24.5 kB
IconButton -- 80.6 kB ▼ -4 B (-0.02% ) 25.3 kB
InputBase -- 75.7 kB ▼ -4 B (-0.02% ) 23.8 kB
ListItem -- 81.6 kB ▼ -4 B (-0.02% ) 25.6 kB
ListSubheader -- 67.7 kB ▼ -4 B (-0.02% ) 21.3 kB
MenuItem -- 82.7 kB ▼ -4 B (-0.02% ) 26 kB
MenuList -- 70.9 kB ▼ -4 B (-0.02% ) 22.2 kB
PaginationItem -- 85.3 kB ▼ -4 B (-0.02% ) 26.4 kB
RadioGroup -- 68.8 kB ▼ -4 B (-0.02% ) 21.4 kB
ScopedCssBaseline -- 67.8 kB ▼ -4 B (-0.02% ) 21.3 kB
Skeleton -- 67.9 kB ▼ -4 B (-0.02% ) 21.5 kB
Snackbar -- 81.5 kB ▼ -4 B (-0.02% ) 25.7 kB
SnackbarContent -- 68.4 kB ▼ -4 B (-0.02% ) 21.6 kB
StepIcon -- 69.5 kB ▼ -4 B (-0.02% ) 21.7 kB
TabPanel -- 70 kB ▼ -4 B (-0.02% ) 22 kB
Tabs -- 90.5 kB ▼ -4 B (-0.01% ) 28.3 kB
Tooltip -- 107 kB ▼ -4 B (-0.01% ) 34 kB
Typography -- 68.5 kB ▼ -4 B (-0.02% ) 21.4 kB
AvatarGroup -- 71.1 kB ▼ -3 B (-0.01% ) 22.6 kB
BottomNavigation -- 67.3 kB ▼ -3 B (-0.01% ) 21.1 kB
Breadcrumbs -- 85 kB ▼ -3 B (-0.01% ) 27 kB
Card -- 67.7 kB ▼ -3 B (-0.01% ) 21.3 kB
CardContent -- 66.9 kB ▼ -3 B (-0.01% ) 21 kB
CardMedia -- 67.2 kB ▼ -3 B (-0.01% ) 21.2 kB
CircularProgress -- 69 kB ▼ -3 B (-0.01% ) 21.8 kB
DialogActions -- 67 kB ▼ -3 B (-0.01% ) 21 kB
DialogContentText -- 68.9 kB ▼ -3 B (-0.01% ) 21.7 kB
Divider -- 67.6 kB ▼ -3 B (-0.01% ) 21.3 kB
ExpansionPanelActions -- 67 kB ▼ -3 B (-0.01% ) 21 kB
ExpansionPanelDetails -- 66.9 kB ▼ -3 B (-0.01% ) 21 kB
FormControl -- 69.3 kB ▼ -3 B (-0.01% ) 21.6 kB
FormControlLabel -- 70.4 kB ▼ -3 B (-0.01% ) 22.2 kB
FormLabel -- 68.4 kB ▼ -3 B (-0.01% ) 21.2 kB
GridList -- 67.4 kB ▼ -3 B (-0.01% ) 21.2 kB
GridListTile -- 68.6 kB ▼ -3 B (-0.01% ) 21.6 kB
GridListTileBar -- 68.1 kB ▼ -3 B (-0.01% ) 21.4 kB
Icon -- 67.7 kB ▼ -3 B (-0.01% ) 21.2 kB
Input -- 77.6 kB ▼ -3 B (-0.01% ) 24.3 kB
InputAdornment -- 70 kB ▼ -3 B (-0.01% ) 22.1 kB
InputLabel -- 70.2 kB ▼ -3 B (-0.01% ) 21.7 kB
Menu -- 94.4 kB ▼ -3 B (-0.01% ) 29.2 kB
OutlinedInput -- 79.7 kB ▼ -3 B (-0.01% ) 24.8 kB
Pagination -- 89 kB ▼ -3 B (-0.01% ) 27.5 kB
Popover -- 88.7 kB ▼ -3 B (-0.01% ) 27.5 kB
Rating -- 75.7 kB ▼ -3 B (-0.01% ) 24.4 kB
Slide -- 31.1 kB ▼ -3 B (-0.03% ) 10.3 kB
SpeedDialIcon -- 69.4 kB ▼ -3 B (-0.01% ) 21.9 kB
Step -- 67.6 kB ▼ -3 B (-0.01% ) 21.2 kB
StepConnector -- 67.6 kB ▼ -3 B (-0.01% ) 21.3 kB
StepContent -- 75.1 kB ▼ -3 B (-0.01% ) 23.6 kB
StepLabel -- 73.4 kB ▼ -3 B (-0.01% ) 22.8 kB
Stepper -- 69.8 kB ▼ -3 B (-0.01% ) 22 kB
SvgIcon -- 67.9 kB ▼ -3 B (-0.01% ) 21.2 kB
TableContainer -- 66.9 kB ▼ -3 B (-0.01% ) 21 kB
TableRow -- 67.4 kB ▼ -3 B (-0.01% ) 21.2 kB
TabScrollButton -- 81.5 kB ▼ -3 B (-0.01% ) 25.6 kB
Zoom -- 29.4 kB ▼ -3 B (-0.03% ) 9.97 kB
@material-ui/system -- 17.2 kB ▼ -2 B (-0.04% ) 4.52 kB
AlertTitle -- 69.1 kB ▼ -2 B (-0.01% ) 21.8 kB
Avatar -- 70 kB ▼ -2 B (-0.01% ) 22 kB
BottomNavigationAction -- 80 kB ▼ -2 B (-0.01% ) 25.4 kB
Box -- 73.8 kB ▼ -2 B (-0.01% ) 22.4 kB
CardActionArea -- 79.6 kB ▼ -2 B (-0.01% ) 25.2 kB
CardActions -- 66.9 kB ▼ -2 B (-0.01% ) 21 kB
FormGroup -- 66.9 kB ▼ -2 B (-0.01% ) 21 kB
Link -- 71.5 kB ▼ -2 B (-0.01% ) 22.7 kB
ListItemAvatar -- 67 kB ▼ -2 B (-0.01% ) 21 kB
ListItemSecondaryAction -- 66.9 kB ▼ -2 B (-0.01% ) 21 kB
ListItemText -- 69.9 kB ▼ -2 B (-0.01% ) 22 kB
Modal -- 15 kB ▲ +2 B (+0.04% ) 5.25 kB
styles/createMuiTheme -- 22.4 kB ▼ -2 B (-0.03% ) 7.75 kB
TableFooter -- 67 kB ▼ -2 B (-0.01% ) 21 kB
TableSortLabel -- 81.9 kB ▼ -2 B (-0.01% ) 26 kB
DialogContent -- 67.1 kB ▼ -1 B (-0.00% ) 21.1 kB
Fade -- 29.4 kB ▼ -1 B (-0.01% ) 9.84 kB
FormHelperText -- 68.2 kB ▼ -1 B (-0.00% ) 21.2 kB
Grow -- 30 kB ▼ -1 B (-0.01% ) 10.1 kB
ListItemIcon -- 67.1 kB ▼ -1 B (-0.00% ) 21.1 kB
Paper -- 67.2 kB ▼ -1 B (-0.00% ) 21 kB
Tab -- 81 kB ▼ -1 B (-0.00% ) 25.8 kB
TableHead -- 67 kB ▼ -1 B (-0.00% ) 21 kB
TabList -- 91.7 kB ▲ +1 B (0.00% ) 29.4 kB
Toolbar -- 67.2 kB ▼ -1 B (-0.00% ) 21.2 kB
ClickAwayListener -- 4.13 kB -- 1.65 kB
colorManipulator -- 3.96 kB -- 1.55 kB
docs:/ -- 12.1 kB -- -1 B
docs:/_app -- 37.2 kB -- -1 B
List -- 67.2 kB -- 21 kB
NoSsr -- 2.18 kB -- 1.03 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.64 kB -- 1.76 kB
SpeedDial -- 91.6 kB -- 29.1 kB
StepButton -- 86.8 kB -- 27.5 kB
SwipeableDrawer -- 98.2 kB -- 30.9 kB
TabContext -- 2.65 kB -- 1.15 kB
Table -- 67.5 kB -- 21.2 kB
TableBody -- 67 kB -- 21 kB
TextareaAutosize -- 5.24 kB -- 2.19 kB
useMediaQuery -- 2.57 kB -- 1.06 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB

Generated by 🚫 dangerJS against 656f0b8

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label May 10, 2020
@eps1lon
Copy link
Member

eps1lon commented May 10, 2020

[docs] Better visually group tocs items b149905.

Could you include before and after? It isn't clear what you're trying to achieve.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 10, 2020 •
edited
Loading

Could you include before and after? It isn't clear what you're trying to achieve.

@eps1lon Sure, here are the 3 objectives, by order of importance:

Before

Capture d’écran 2020-05-10 à 19 05 51

After

Capture d’écran 2020-05-10 à 19 05 45

  1. To visually differentiate an item that wraps with two consecutive items, leverage the padding instead of the line-height. A couple of times, working on [ToggleButton] Reduce gap with ButtonGroup #20967, I thought "button" was an item on its own, I tried to hover it.

(⤴️ what motivated this change in the first place, the two other ones are not important. I have only done them because I was already "at it".)

  1. To compensate for the smaller left padding (12px -> 8px), reduce the width of the border from 4 to 3 pixels, de-duplicate the border width information at the same time.
  2. Make the TOCs style less impacted by spacing value changes.

eps1lon
eps1lon previously requested changes May 11, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the TOCs style less impacted by spacing value changes.

Why? This is the point of spacing.

packages/material-ui-styles/src/withStyles/withStyles.test.js Outdated Show resolved Hide resolved
packages/material-ui/src/test-utils/describeConformance.js Outdated Show resolved Hide resolved
oliviertassinari and others added 2 commits May 11, 2020 12:08
@oliviertassinari @eps1lon
Update packages/material-ui/src/test-utils/describeConformance.js
99982ec 
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@oliviertassinari @eps1lon
Update packages/material-ui-styles/src/withStyles/withStyles.test.js
3233b7e 
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 11, 2020 •
edited
Loading

Why? This is the point of spacing.

@eps1lon Yeah ok, we would need to think something at a systemic level for the documentation. I'm reverting. My concern was that it doesn't look great with too different values (e.g. 2 or 16), but it's true for the rest of the documentation layout. Thanks

@oliviertassinari oliviertassinari merged commit 5dfb13c into mui:master May 11, 2020
@oliviertassinari oliviertassinari deleted the batch-small-changes-v12 branch May 11, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

Assignees
No one assigned
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-pr-bot @eps1lon