Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Introduce visuallyHidden style utility #21413
[system] Introduce visuallyHidden style utility #21413
Changes from 19 commits
c953f9e
4e9c6b8
dfcc14d
3cec1e1
829b793
fcae609
c7c7170
4cccf65
f8ab6bd
ce4cd15
4348541
070f2d9
ac287b7
e095fe5
393c245
592b451
6abfaf3
d57387c
7ef59e2
299292b
4c2256a
1d3d245
6d084a5
d919b9b
e33085c
236450b
e50d107
aa96cc6
1ecd2e9
b0d1158
54a1c6d
ea9ba89
2fa6d93
085286f
1cd1658
9de377c
ddfbf4e
0dd8163
8807efc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more realistic scenario where the
visuallyHidden
would be usedcc @eps1lon let me know what do you think about this example, although it may be too complicated now.. :\
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the demo, I can't use the keyboard to navigate the option, not notice any focusable style. I'm also not sure about the complexity of the demo. https://www.scottohara.me/blog/2017/04/14/inclusively-hidden.html seems to have a few nice and simple use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just add a simple example with an
<a />
element? Would be nice if it the code is short and immediately shown below the example. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the link example, I can add another one for the date start and end example if you think this is not enough