[docs] Restore ButtonBases images #23083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
oliviertassinari
approved these changes
Oct 16, 2020
|
No bundle size changes comparing a92256e...2045547 |
This was referenced Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23082 by restoring images used in /buttons that were owned by /image-list and removed in #22395.
The takeaway is to not blindly DRY up your code by re-using resources from other components. These should've been hoisted so that it's clear that they're general purpose and not just used by ImageList. This seems to be common practice but should be avoided for future images.
https://deploy-preview-23083--material-ui.netlify.app/components/buttons/#complex-buttons
Closes #23084