-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ClickAwayListener] Fix mounting behavior in Portals in React 17 #23367
[ClickAwayListener] Fix mounting behavior in Portals in React 17 #23367
Conversation
Will we backport #23311 too? |
Let's not stress this and take one step at a time. React 17 is just fresh and I have not seen a reason to rush this out. I'm not aware of any big feature that React 17 needs to be rolled out as soon as possible |
This reverts commit d2dd1e7.
Agree, we don't need to rush it. I was wondering about the coming weeks. Should we allow developers to upgrade React and Material-UI independently? |
This is already possible. The main offender is npm 7. If you're upgrading npm and React 17 at the same time then you're on your own. |
Details of bundle changes.Comparing: 9196f19...e4216c1 Details of page changes
|
Backport of #23315
Closes #23215 (magic comment for codesandbox)
Test plan