[docs] Remove dead generatePropTypeDescription method #25188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fayzzzm
commented
Mar 4, 2021
| @@ -47,20 +47,24 @@ function getChained(type: PropTypeDescriptor) { | |||
| return false; | |||
| } | |||
|
|
|||
| function escapeCell(value: string): string { | |||
| export function escapeCell(value: string): string { | |||
There was a problem hiding this comment.
I added an export here because the "buildApi" file duplicated these functions.
I deleted the duplicates, exported them from here, and used them there.
fayzzzm
commented
Mar 4, 2021
2 tasks
oliviertassinari
changed the title
oliviertassinari
added
core
oliviertassinari
approved these changes
Mar 4, 2021
|
@fayzzzm Great, first step done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By observing files, we have found that
generatePropTypeDescriptionand several other functions have been duplicated at pathpath1: docs/scripts/buildApi.tsbut at the path ofpath2: docs/src/modules/utils/generatePropTypeDescription.ts, we have a separate file with all of these functions. So I've decided to delete frompath1all duplicate functions and import them frompath2.More: discussion link