Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Move StyledEngineProvider to @material-ui/core/styles #26265

Merged
merged 10 commits into from
May 13, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented May 12, 2021

BREAKING CHANGE v5

StyledEngineProvider location is changed. The previous location is deprecated, it will be removed in v5.beta.

-import StyledEngineProvider from '@material-ui/core/StyledEngineProvider ';
+import { StyledEngineProvider } from '@material-ui/core/styles';

Closes #23208
One of #20012

@@ -401,5 +401,4 @@ export * from './GlobalStyles';
/**
* @deprecated will be removed in v5 beta, please use StyledEngineProvider instead
*/
export { default as StylesProvider } from './StyledEngineProvider';
export { default as StyledEngineProvider } from './StyledEngineProvider';
export { StyledEngineProvider } from './styles';
Copy link
Member Author

@mnajdova mnajdova May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are changing it a second time already 😞

@mui-pr-bot
Copy link

mui-pr-bot commented May 12, 2021

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 110fabd

packages/material-ui/src/styles/index.d.ts Outdated Show resolved Hide resolved
packages/material-ui/src/index.js Outdated Show resolved Hide resolved
packages/material-ui/src/index.js Show resolved Hide resolved
mnajdova and others added 2 commits May 12, 2021 13:28
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@mnajdova mnajdova marked this pull request as ready for review May 12, 2021 11:28
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I have updated the PR's description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not found @material-ui/core/ThemeProvider when minimizing bundle size in create react app
3 participants