Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[theme] Improve default
primary
,secondary
anderror
theme palette #26555[theme] Improve default
primary
,secondary
anderror
theme palette #26555Changes from 12 commits
c4769db
cc49082
67ad326
ab584bc
576fc04
56c106d
0c90ea0
7b279ab
4057597
0fbddad
8916d2c
d723254
ffa7c77
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
defaultTheme
here to remove hard coded color in the test below.I wonder should
defaultTheme
be exported asdefaultLightTheme
from@material-ui/core/styles
also?In my side project I use
defaultTheme
a lot and it is quite annoying to callcreateTheme()
everytime.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we include the color in the warning? If not then we can follow-up. Otherwise I'd make sure the color is included in the assertion which means we can get rid of the (potentially wrong) code comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 lines was there at the beginning (1 more is added because
info
is changed tocyan[500]
, it's sound intentional that we expect the colors to falls below contrast ratio. I was confused at first about this test so I added comments at the end. Any suggestion?