[test] Update tests with latest state of StrictMode compatibility #27042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jun 30, 2021
|
|
||
| before(function beforeHook() { | ||
| if (!/jsdom/.test(window.navigator.userAgent)) { | ||
| // FIXME This test suite is extremely flaky in test:karma |
There was a problem hiding this comment.
Was likely flaky due to real timers.
eps1lon
force-pushed
the
test/StrictMode
branch
2 times, most recently
from
f69c6c0
to
9627c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13394
Every test not using StrictMode now is annotated with
StrictModeViolationand the reason.Follow-up:
CalendarPicker([CalendarPicker] Use transition components from core instead of a custom implementation #27043)