Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0-beta.1 #27230

Merged
merged 4 commits into from
Jul 14, 2021
Merged

v5.0.0-beta.1 #27230

merged 4 commits into from
Jul 14, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 11, 2021

I have updated the version of the private packages to a pinned: 5.0.0. The objective is so we can keep it the same going forward, avoiding diffs/noise in the release PRs. Private packages are never released, the version is useless from what I understand. We already use this tradeoff in the examples.

Important, a preview of how the header of the release looks and feels like:


Capture d’écran 2021-07-11 à 13 24 48


As a side thought: We had 13 contributors in 10 days, the community has been quiet in the last few days. It seems that the pattern is older than this. We might want to spend more time on the issues and PRs, and less time on the ongoing initiatives. We were often at 20 contributors/week in the past, I was dedicating 80% of my time to issues and PRs, not initiatives. 80% was probably too much, I guess we need to find a balance and a reasonable target, it's a tension:

  • too much time on issues & PRs mean we can't take on the boldest moves, innovate
  • not enough time on issues & PRs mean we can't build the most loved UI components, leaving too many friction points behind, opening the door for competitors to catch up with what we do the best.

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 11, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 5708ded

docs/package.json Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member Author

@eps1lon Are you OK with the version change for the private packages? I wasn't too sure that it would be better, it seemed simpler though.

oliviertassinari and others added 2 commits July 14, 2021 17:27
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
@oliviertassinari oliviertassinari merged commit 8a4b895 into mui:next Jul 14, 2021
@oliviertassinari oliviertassinari deleted the v5.0.0-beta.1 branch July 14, 2021 15:49
@eps1lon
Copy link
Member

eps1lon commented Jul 21, 2021

@oliviertassinari Did you run yarn release:version or did you manually update the versions?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 21, 2021

@eps1lon I have used yarn release:version first, then did manual edits. For instance, reverting the version change to packages where only the test files changed.

@eps1lon
Copy link
Member

eps1lon commented Jul 21, 2021

Well you made a mistake when manually editing the versions since you forgot to bump @material-ui/codemod.

@oliviertassinari
Copy link
Member Author

Thanks for raising. I think that I forgot to rerun the package version script after I rebased the branch to take in the changes between Monday and Wednesday.

@zannager zannager added docs Improvements or additions to the documentation v5.x labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants