[codemod] Fix optimal-imports to support v4 and v5-alpha, beta

[siriwatknp]

Open as draft to discuss about this change. I can reproduce with @material-ui/core latest(4.12.3) that codemod cannot transform import blueGrey from "@material-ui/core/colors/blueGrey";

Got the same error as in #28542

 ERR /Users/siriwatknp/practice-repos/mui-colors-codemod/src/App.js Transformation error (Cannot find module '@material-ui/core/modern/colors' Require stack: - /Users/siriwatknp/Personal-Repos/material-ui/packages/mui-codemod/src/v5.0.0/optimal-imports.js - /Users/siriwatknp/Personal-Repos/material-ui/packages/mui-codemod/src/v5.0.0/preset-safe.js - /Users/siriwatknp/Personal-Repos/material-ui/node_modules/jscodeshift/src/Worker.js)
Error: Cannot find module '@material-ui/core/modern/colors'

but by using /es/ folder, it works. @mnajdova what is the reason to use /modern/ at that time?

Note: in node_modules, I only see folder es and esm but no sign of modern.

• I have followed (at least) the PR section of the contributing guide.

[mui-pr-bot]

No bundle size changes

Generated by 🚫 dangerJS against 927f135

[mnajdova]

The modern bundle was introduced in v5 with #22814 this is why when running on v4 it fails. The problematic thing I think is that the codemod could be run at any time during the upgrade (when still using v4, or when using v5).

The implemented changes would not work if someone upgraded to some v5 alpha version and then run the codemod. So maybe, in the end, the best solution would be to use the es by default, but if it does not exists to fallback to modern.

cc @eps1lon for thoughts.

[siriwatknp]

The modern bundle was introduced in v5

@mnajdova Got it. added try catch to support both v4 and v5-alpha, beta. Tested locally, both works! no more error.

[mnajdova]

This makes sense to me 👍 Thanks @siriwatknp

[eps1lon]

that codemod cannot transform import blueGrey from "@material-ui/core/colors/blueGrey";

The codemod should not transform these paths. It should only transform supported paths and give up on everything else. To catch unsupported paths we can recommend the way we do it via Eslint.

Trying to guess the correct path from an unsupported path is a constant uphill battle. I would not recommend it though it's no longer my decision.

[siriwatknp]

To catch unsupported paths we can recommend the way we do it via Eslint

Noted on this point to consider in the future. But I think this PR also help people with the migration which also benefit us with less issue (I hope), so I am merging it.