Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTimePicker] Change showToolbar default value to false #30258

Closed
wants to merge 3 commits into from
Closed

[DateTimePicker] Change showToolbar default value to false #30258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e45b0c
change showToolbar default value to false
alisasanib Dec 18, 2021
d091aeb
update previous tests by passing showToolbar as a prop
alisasanib Dec 18, 2021
e2be163
adding new tests to check toolbar is rendered properly when showToolb…
alisasanib Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/mui-lab/src/DateTimePicker/DateTimePicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import * as React from 'react';
import TextField from '@mui/material/TextField';
import DateTimePicker from '@mui/lab/DateTimePicker';
import { expect } from 'chai';
import { screen } from 'test/utils';
import { createPickerRenderer } from '../internal/pickers/test-utils';

describe('<DateTimePicker />', () => {
Expand All @@ -16,4 +18,17 @@ describe('<DateTimePicker />', () => {
/>,
);
});
it('prop `showToolbar` – renders toolbar in DateTimePicker', () => {
render(
<DateTimePicker
open
showToolbar
onChange={() => {}}
value={null}
renderInput={(params) => <TextField {...params} />}
/>,
);

expect(screen.getByMuiTest('picker-toolbar')).toBeVisible();
});
});
2 changes: 1 addition & 1 deletion packages/mui-lab/src/DateTimePicker/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export function useDateTimePickerDefaultizedProps<Props extends BaseDateTimePick
ampm: willUseAmPm,
ampmInClock: true,
orientation,
showToolbar: true,
showToolbar: false,
allowSameDateSelection: true,
minDate: minDateTime ?? minDate,
minTime: minDateTime ?? minTime,
Expand Down
1 change: 1 addition & 0 deletions packages/mui-lab/src/DesktopDateTimePicker/DesktopDateTimePicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ describe('<DesktopDateTimePicker />', () => {
renderInput={(params) => <TextField {...params} />}
value={null}
open
showToolbar
onClose={handleClose}
/>,
);
Expand Down
17 changes: 17 additions & 0 deletions packages/mui-lab/src/MobileDateTimePicker/MobileDateTimePicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ describe('<MobileDateTimePicker />', () => {
setDate(newDate);
onChangeMock(newDate);
}}
showToolbar
renderInput={(params) => <TextField autoFocus {...params} />}
/>
);
Expand Down Expand Up @@ -128,6 +129,7 @@ describe('<MobileDateTimePicker />', () => {
renderInput={(params) => <TextField {...params} />}
onChange={() => {}}
open
showToolbar
value={adapterToUse.date('2021-11-20T10:01:22.000')}
/>,
);
Expand All @@ -139,12 +141,27 @@ describe('<MobileDateTimePicker />', () => {
expect(screen.getByMuiTest('datetimepicker-toolbar-day')).to.have.text('Nov 20');
});

it('prop `showToolbar` – renders toolbar in MobileDateTimePicker', () => {
render(
<MobileDateTimePicker
open
showToolbar
onChange={() => {}}
value={adapterToUse.date('2021-11-20T10:01:22.000')}
renderInput={(params) => <TextField {...params} />}
/>,
);

expect(screen.getByMuiTest('picker-toolbar')).toBeVisible();
});

it('can render seconds on view', () => {
render(
<MobileDateTimePicker
renderInput={(params) => <TextField {...params} />}
onChange={() => {}}
open
showToolbar
views={['seconds']}
value={adapterToUse.date('2021-11-20T10:01:22.000')}
/>,
Expand Down