Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix source code links on the Templates page #31425

Merged
merged 2 commits into from
Mar 13, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Mar 11, 2022

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Mar 11, 2022
@danilo-leal danilo-leal requested a review from a team March 11, 2022 19:39
@mui-bot
Copy link

mui-bot commented Mar 11, 2022

No bundle size changes

Generated by 🚫 dangerJS against 24622d7

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Mar 12, 2022
@@ -89,7 +89,7 @@ function layouts(t) {
href: '/getting-started/templates/sticky-footer/',
source:
// #default-branch-switch
'https://github.com/mui/material-ui/tree/master/docs/data/material/getting-started/templates/sticky-footer',
'https://github.com/mui/material-ui/tree/v4.x/docs/src/pages/getting-started/templates/sticky-footer',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is v5, not v4

@oliviertassinari oliviertassinari removed the status: waiting for author Issue with insufficient information label Mar 12, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 12, 2022

I have pushed a new commit to replicate the solution of #23821. There might be a deeper root problem with the service worker, but at least, this change allows the docs deployements to be more immutable.

@danilo-leal danilo-leal merged commit 82f2a3f into mui:master Mar 13, 2022
@danilo-leal danilo-leal deleted the adjust-templates-source-code-link branch March 13, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] template links broken
3 participants