-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update mui-x on material-ui navigation #31810
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Are we talking about the old doc infra or the new one If it's the new one, do you want to list all the pages of the Data Grid and Date Pickers or just the 2-3 most important ? |
This is the new infra (X docs separated from Core). |
If you mean the navigation in https://mui.com/x/react-data-grid/, it's beyond the scope of this PR and should be discussed with the X team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean the navigation in https://mui.com/x/react-data-grid/, it's beyond the scope of this PR and should be discussed with the X team.
Ah, then ignore my comment above! I have just now realized that this is the MUI X reference within Material UI docs. In that sense, I think it's all good! I've just reviewed a bit of the wording but I'll be requesting Sam's review for further improvement.
Thanks, that's a lot better! I'll commit and wait for another review from Sam. |
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
…/remove-datepicker
…al-ui into docs/remove-datepicker
@@ -0,0 +1,19 @@ | |||
# Date / Time pickers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for capitalizing Time here? The headline seems to be referring to the general category of these components, as opposed to <DatePicker>
and <TimePicker>
themselves.
Also, I think it looks a lot cleaner to ditch the "/" in favor of "and."
# Date / Time pickers | |
# Date and time pickers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suppose it's because you can also have <DateTimePicker>
. But I personally think it's way cleaner the way you're proposing here.
This page talks about date and time pickers, but the blog post about the move seems to suggest that it is just the date pickers moving. Or does the |
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Yes, we meant the same thing (the whole pickers family). Any suggestion to make it clear? |
@samuelsycamore we have a lot of pickers (date picker, time picker, date time picker, date range picker, year picker, ...) We chose to name the package And on the other hand, being more precise, like |
Maybe I'm might be coming late to this discussion (and this PR seems like not the best place to do it) but... wouldn't it make more sense to use Leaving it broader also gives the benefit of the doubt for the future — what if the emoji picker ends up sounding like a good idea one or two years from now? We'd just include it in the |
@danilo-leal here is the Slack discussion I don't think the term "picker" creates a component family consistent enough to group them in a single package. For me this package is only intended for pickers that have something to do with to time. |
Shoot, seeing now that I even voted in favor of |
In this case, I would propose that we refer to |
@samuelsycamore @danilo-leal I updated the url to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go with this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a teeny tiny tweak to the title, otherwise it looks good to me!
docs/data/material/components/pickers/lab-date-and-time-pickers.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Changes
Added the redirects for those who directly access the old URL (will land on the MUI X docs)
Update the navigation UI by grouping data-grid & date-picker under MUI X and mark the lab as legacy.
Added a deprecated page as a summary of the afford and provide useful links to other resources.
Preview: https://deploy-preview-31810--material-ui.netlify.app/material-ui/lab-date-and-time-pickers/