Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add BackdropUnstyled docs #31855

Closed
wants to merge 1 commit into from
Closed

[docs] Add BackdropUnstyled docs #31855

wants to merge 1 commit into from

Conversation

michaldudak
Copy link
Member

Moved the BackdropUnstyled to the Base docs and created an unstyled demo.

@michaldudak michaldudak added docs Improvements or additions to the documentation component: backdrop This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Mar 17, 2022
@michaldudak michaldudak requested a review from a team March 17, 2022 11:14
@michaldudak michaldudak mentioned this pull request Mar 17, 2022
Closed
17 tasks
@mui-bot
Copy link

mui-bot commented Mar 17, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against f9af023

hbjORbj
hbjORbj approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

docs/data/base/components/backdrop/backdrop.md
import BackdropUnstyled from '@mui/base/BackdropUnstyled';
```

The backdrop signals to the user of a state change within the application and can be used for creating loaders, dialogs, and more.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The backdrop signals to the user of a state change within the application and can be used for creating loaders, dialogs, and more.
The backdrop signals to the user of a state change within the application and hence can be used for creating loaders, dialogs, and more.

@michaldudak
Copy link
Member Author

As discussed in #31859 (comment) - BackdropUnstyled doesn't make much sense without styles.
Closing the PR.

@michaldudak michaldudak deleted the backdrop-unstyled-docs branch May 12, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
component: backdrop This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @mui-bot @hbjORbj