Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Portal] Copy Portal docs to the Base space #31959

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

michaldudak
Copy link
Member

Copied the Portal docs to the Base space and adapted the demos' imports.

@michaldudak michaldudak added component: Portal The React component. docs Improvements or additions to the documentation labels Mar 23, 2022
@mui-bot
Copy link

mui-bot commented Mar 23, 2022

No bundle size changes

Generated by 🚫 dangerJS against 8e01b36

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 23, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2022
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Co-authored-by: Benny Joo <sldisek783@gmail.com>
@michaldudak michaldudak merged commit 2c70b02 into mui:master Mar 24, 2022
@michaldudak michaldudak deleted the docs/portal branch March 24, 2022 13:29
@samuelsycamore
Copy link
Member

Should we be implementing the style guide on these pages as they're being moved over? Or is that something we want to come back to once they're all ready?

@michaldudak
Copy link
Member Author

@samuelsycamore Feel free to create PRs with improvements where you see fit. I'd like to simply move/copy content between spaces in a single PR and then iterate on it in subsequent ones. This would separate "technical" (movement of docs between subsites) and "content" updates and let us finish the migration sooner (at the cost of not having the content perfect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Portal The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants